Preserve rules from previous passing CI when current CI fails

When a PR has a new commit that fails CI (or CI is still pending),
preserve the existing synced rules from the previous passing commit
instead of removing them. Also don't remove the in-test-rules label
since the rule is still in test-rules (just an older version).

This prevents:
1. Rules disappearing when CI is slow or temporarily failing
2. False "manual exclusion" detection when the label was removed
   by the script due to CI failure, not by a user

Changes:
- sync_test_rules.py: Remove label removal on CI failure, add file
  preservation logic
- sync_shared_samples.py: Add CI checking (was missing entirely),
  with file preservation for failing/pending CI

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: aidenmitchell

.github/scripts/sync_shared_samples.py

@@ -31,6 +31,8 @@
     DEFAULT_AUTHOR_TAG_PREFIX,
     DEFAULT_RULE_STATUS_PREFIX,
     DEFAULT_OPEN_PR_TAG,
+    DEFAULT_REQUIRED_CHECK_NAME,
+    DEFAULT_REQUIRED_CHECK_CONCLUSION,
     # GraphQL
     create_graphql_session,
     fetch_all_prs,
@@ -76,6 +78,11 @@
 SKIP_BULK_PRS = os.getenv('SKIP_BULK_PRS', 'true').lower() == 'true'
 MAX_RULES_PER_PR = int(os.getenv('MAX_RULES_PER_PR', str(DEFAULT_MAX_RULES_PER_PR)))
 
+# Action completion checks
+CHECK_ACTION_COMPLETION = os.getenv('CHECK_ACTION_COMPLETION', 'true').lower() == 'true'
+REQUIRED_CHECK_NAME = os.getenv('REQUIRED_CHECK_NAME', DEFAULT_REQUIRED_CHECK_NAME)
+REQUIRED_CHECK_CONCLUSION = os.getenv('REQUIRED_CHECK_CONCLUSION', DEFAULT_REQUIRED_CHECK_CONCLUSION)
+
 # Create output folder if it doesn't exist
 if not os.path.exists(OUTPUT_FOLDER):
     os.makedirs(OUTPUT_FOLDER)
@@ -307,6 +314,18 @@ def handle_pr_rules(graphql_session, rest_session):
         latest_sha = pr.head_sha
         print(f"\tLatest commit SHA: {latest_sha}")
 
+        # Check if required checks have completed (in-memory check)
+        if CHECK_ACTION_COMPLETION:
+            if not pr.has_required_check(REQUIRED_CHECK_NAME, REQUIRED_CHECK_CONCLUSION):
+                print(f"\tSkipping PR #{pr_number}: Required check '{REQUIRED_CHECK_NAME}' has not completed with conclusion '{REQUIRED_CHECK_CONCLUSION}'")
+                # Preserve existing synced files from previous passing commits
+                prefix = f"{pr_number}_"
+                for filename in os.listdir(OUTPUT_FOLDER):
+                    if filename.startswith(prefix) and filename.endswith('.yml'):
+                        print(f"\tPreserving existing file: {filename}")
+                        new_files.add(filename)
+                continue
+
         # Use files from GraphQL data (already fetched)
         files = pr.files
 

.github/scripts/sync_test_rules.py

@@ -218,9 +218,13 @@ def handle_pr_rules(graphql_session, rest_session):
         if CHECK_ACTION_COMPLETION:
             if not pr.has_required_check(REQUIRED_CHECK_NAME, REQUIRED_CHECK_CONCLUSION):
                 print(f"\tSkipping PR #{pr_number}: Required check '{REQUIRED_CHECK_NAME}' has not completed with conclusion '{REQUIRED_CHECK_CONCLUSION}'")
-                # Remove in-test-rules label if previously applied
-                if pr.has_label(IN_TEST_RULES_LABEL):
-                    remove_label(rest_session, REPO_OWNER, REPO_NAME, pr_number, IN_TEST_RULES_LABEL)
+                # Preserve existing synced files from previous passing commits
+                # Don't remove in-test-rules label since the rule is still in test-rules (older version)
+                prefix = f"{pr_number}_"
+                for filename in os.listdir(OUTPUT_FOLDER):
+                    if filename.startswith(prefix) and filename.endswith('.yml'):
+                        print(f"\tPreserving existing file: {filename}")
+                        new_files.add(filename)
                 continue
 
         # Use files from GraphQL data (already fetched)