Skip to content

Conversation

@JFarina5
Copy link
Member

@JFarina5 JFarina5 commented Jan 6, 2026

Description

Added coverage for a FN, checking for things such as 'account/cloud suspended/at risk', also added check for auth failures and negated legit security trainings (noticed a few FPs in hunt results initially).

Associated samples

Associated hunts

Hunts showed no benign hits for both the 14 and 30 day hunts.

@JFarina5 JFarina5 requested a review from a team as a code owner January 6, 2026 19:12
@github-actions github-actions bot added the in-test-rules PR is in our testing suite to collect telemetry label Jan 6, 2026
github-actions bot added a commit that referenced this pull request Jan 6, 2026
@JFarina5
Copy link
Member Author

JFarina5 commented Jan 7, 2026

Mode results look good, flagging on one benign message that the rule doesn't actually fire on. Not really sure why its showing in Mode.

@JFarina5 JFarina5 added the review-needed Indicates that a PR is waiting for review label Jan 7, 2026
@JFarina5 JFarina5 removed the review-needed Indicates that a PR is waiting for review label Jan 8, 2026
github-actions bot added a commit that referenced this pull request Jan 8, 2026
Add conditions to exclude legitimate notifications and job requests.
github-actions bot added a commit that referenced this pull request Jan 12, 2026
@JFarina5 JFarina5 added the review-needed Indicates that a PR is waiting for review label Jan 12, 2026
@JFarina5
Copy link
Member Author

JFarina5 commented Jan 12, 2026

Last commit was negations for FPs found in test results. Current results look good.

github-actions bot added a commit that referenced this pull request Jan 12, 2026
github-actions bot added a commit that referenced this pull request Jan 12, 2026
github-actions bot added a commit that referenced this pull request Jan 12, 2026
github-actions bot added a commit that referenced this pull request Jan 12, 2026
github-actions bot added a commit that referenced this pull request Jan 12, 2026
@JFarina5 JFarina5 requested a review from zoomequipd January 13, 2026 14:19
@JFarina5 JFarina5 removed the review-needed Indicates that a PR is waiting for review label Jan 14, 2026
Excluding technical documentation and 'free trial' type messages.
github-actions bot added a commit that referenced this pull request Jan 14, 2026
@JFarina5 JFarina5 added the review-needed Indicates that a PR is waiting for review label Jan 15, 2026
@JFarina5
Copy link
Member Author

Mode results look solid after the latest changes

github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
github-actions bot added a commit to aidenmitchell/sublime-rules that referenced this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-test-rules PR is in our testing suite to collect telemetry review-needed Indicates that a PR is waiting for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants