inline edit redefined

Author: SM_SAYEED

app.py

@@ -1060,8 +1060,7 @@ def property_detail(property_name, tab):
                         conn.commit()
                     upload_message = f"Linked folder: imported {imported} item(s)."
 
-            # 3) Upload a ZIP → push contents to Drive <root>/<property>/<tab> → import--Right now I am not using this due to not having a shared drive in google workspace.
-            # When I do use workspace, this Zip branch must be further refined such that it becomes deterministic on computed parent folder.
+            # 3) Upload a ZIP → push contents to Drive <root>/<property>/<tab> → import
             elif request.form.get('zip_upload'):
                 if 'zipfile' not in request.files or request.files['zipfile'].filename == '':
                     upload_message = "No ZIP file selected."
@@ -1074,6 +1073,10 @@ def property_detail(property_name, tab):
                         service = get_drive_service()
                         target_folder_id = drive_ensure_property_tab_folder(service, root_id, property_name, tab)
 
+                        # Hard guard so we never upload into Drive 'root'
+                        if not target_folder_id or target_folder_id in ("root", "", None):
+                            raise RuntimeError("Refusing to upload: invalid Drive parent (would create in root).")
+
                         data = zf.read()
                         z = zipfile.ZipFile(io.BytesIO(data))
                         uploaded = 0
@@ -1146,9 +1149,16 @@ def property_detail(property_name, tab):
                             (new_desc, property_name, tab, row_filename),
                         )
                     conn.commit()
+                # AJAX? return JSON so the page doesn't reload
+                if request.headers.get('X-Requested-With') == 'XMLHttpRequest':
+                    return jsonify({"ok": True, "filename": row_filename})
+                # Non-AJAX fallback
                 edit_message = f"Updated info for {row_filename}."
 
         except Exception as e:
+            # AJAX error?
+            if request.headers.get('X-Requested-With') == 'XMLHttpRequest':
+                return jsonify({"ok": False, "error": str(e)}), 400
             upload_message = f"Error: {e}"
 
     # ---- fetch current uploads (Drive-only for property pages) ----

templates/property_detail.html

@@ -68,18 +68,18 @@ <h3>Add a {{ pretty_title }} {{ tab.title() }} from Google Drive</h3>
 
         <!-- Link a FOLDER (import all allowed files) -->
         <form method="post" class="stack" style="margin-bottom:1em;">
-          <div class="small">Or link a Drive FOLDER (we’ll import all allowed files directly under it).</div>
+          <div class="small">Or link a Drive FOLDER (we’ll import all allowed files, including subfolders).</div>
           <div>
             <input type="text" name="drive_folder_link" placeholder="Drive FOLDER link or folder ID" style="width:560px" required>
             <button type="submit" name="link_folder" value="1">Link Folder</button>
           </div>
         </form>
 
-        <!-- Upload a ZIP and push to Drive -->
+        <!-- Upload a ZIP and push to Drive (currently optional) -->
         <form method="post" enctype="multipart/form-data" class="stack">
           <div class="small">Or upload a .zip; allowed files inside will be uploaded to Drive automatically.</div>
           <div>
-            <input type="file" name="zipfile" accept=".zip" required>
+            <input type="file" name="zipfile" accept=".zip">
             <button type="submit" name="zip_upload" value="1">Upload ZIP to Drive</button>
           </div>
         </form>
@@ -115,7 +115,7 @@ <h3>Add a {{ pretty_title }} {{ tab.title() }} from Google Drive</h3>
             {% if tab == 'dataset' %}
               <td>
                 {% if admin %}
-                  <form method="post" style="display:inline;">
+                  <form method="post" class="row-edit" style="display:inline;">
                     <input type="hidden" name="row_filename" value="{{ filename }}">
                     <input type="text" name="row_source" value="{{ source or '' }}" size="18">
                 {% else %}
@@ -131,7 +131,7 @@ <h3>Add a {{ pretty_title }} {{ tab.title() }} from Google Drive</h3>
                   <button type="submit" name="edit_row" value="1" style="margin-left:6px;">Save</button>
                   </form>
                 {% else %}
-                  <form method="post" style="display:inline;">
+                  <form method="post" class="row-edit" style="display:inline;">
                     <input type="hidden" name="row_filename" value="{{ filename }}">
                     <input type="text" name="row_description" value="{{ description or '' }}" size="22">
                     <button type="submit" name="edit_row" value="1" style="margin-left:6px;">Save</button>
@@ -150,18 +150,18 @@ <h3>Add a {{ pretty_title }} {{ tab.title() }} from Google Drive</h3>
 
             <td>
               {% if (storage or 'local') == 'drive' %}
-                {% if preview_url %}<a href="{{ preview_url }}" target="_blank">View</a>{% endif %}
-                {% if download_url %} | <a href="{{ download_url }}" target="_blank">Download</a>{% endif %}
+                {% if preview_url %}<a href="{{ preview_url }}" target="_blank" rel="noopener">View</a>{% endif %}
+                {% if download_url %} | <a href="{{ download_url }}" target="_blank" rel="noopener">Download</a>{% endif %}
               {% else %}
                 {% if tab == 'dataset' and (filename.endswith('.csv') or filename.endswith('.npy')) %}
                   {% set tname = table_map.get(filename) %}
                   {% if tname %}
-                    <a href="{{ url_for('public_view', table=tname) }}" target="_blank">View</a>
+                    <a href="{{ url_for('public_view', table=tname) }}" target="_blank" rel="noopener">View</a>
                   {% else %}
                     <span class="small">No table yet</span>
                   {% endif %}
                 {% elif tab == 'results' %}
-                  <a href="{{ url_for('view_result_file', property_name=property_name, tab=tab, filename=filename) }}" target="_blank">View</a>
+                  <a href="{{ url_for('view_result_file', property_name=property_name, tab=tab, filename=filename) }}" target="_blank" rel="noopener">View</a>
                 {% endif %}
                   | <a href="{{ url_for('uploaded_file', filename=property_name ~ '/' ~ tab ~ '/' ~ filename) }}" download>Download</a>
               {% endif %}
@@ -187,5 +187,37 @@ <h3>Add a {{ pretty_title }} {{ tab.title() }} from Google Drive</h3>
     <a class="return-home" href="{{ url_for('public_home') }}">Return to Home</a>
     <a class="return-home" href="{{ url_for('materials_portal') }}" style="margin-left:1.5em;">Back to Materials Database</a>
   </div>
+
+  {% if admin %}
+  <script>
+    // Intercept per-row Save to avoid page reload (preserves other unsaved edits)
+    document.querySelectorAll('form.row-edit').forEach(function(form) {
+      form.addEventListener('submit', async function (e) {
+        e.preventDefault();
+        const fd = new FormData(form);
+        // Ensure the intent flag is present
+        if (!fd.has('edit_row')) fd.append('edit_row', '1');
+        const btn = form.querySelector('button[type="submit"]');
+        const old = btn.textContent;
+        btn.disabled = true;
+
+        try {
+          const resp = await fetch(location.href, {
+            method: 'POST',
+            body: fd,
+            headers: { 'X-Requested-With': 'XMLHttpRequest' }
+          });
+          let data = {};
+          try { data = await resp.json(); } catch { /* ignore */ }
+          btn.textContent = data.ok ? 'Saved ✓' : 'Saved';
+        } catch (err) {
+          btn.textContent = 'Error';
+        }
+
+        setTimeout(() => { btn.disabled = false; btn.textContent = old; }, 1200);
+      });
+    });
+  </script>
+  {% endif %}
 </body>
 </html>