"Fix: Drive clip detection and eliminate unreachable code"

Author: SM_SAYEED

app.py

@@ -417,38 +417,39 @@ def extract_drive_id(link):
 def public_clips():
     admin = session.get('admin', False)
     message = ""
+    db_filename = None
 
-    # Handle upload or link if admin and POST
     if admin and request.method == 'POST':
-        file = request.files.get('file')
-        link = request.form.get('link', '').strip()
+        action = request.form.get('action', '')
         title = request.form.get('title', '').strip()
         description = request.form.get('description', '').strip()
-        db_filename = None
 
         if not title:
             message = "Title is required."
-        elif file and allowed_music_file(file.filename):
-            filename = secure_filename(file.filename)
-            upload_folder = os.path.join(app.config['UPLOAD_FOLDER'], 'clips')
-            os.makedirs(upload_folder, exist_ok=True)
-            filepath = os.path.join(upload_folder, filename)
-            file.save(filepath)
-            db_filename = 'clips/' + filename
-        elif link:
-            media_type = request.form.get('media_type', 'audio')  # get file type from form (mp3 or mp4)
+        elif action == 'upload_file':
+            file = request.files.get('file')
+            if not file or not allowed_music_file(file.filename):
+                message = "Please upload a valid music or video file."
+            else:
+                filename = secure_filename(file.filename)
+                upload_folder = os.path.join(app.config['UPLOAD_FOLDER'], 'clips')
+                os.makedirs(upload_folder, exist_ok=True)
+                filepath = os.path.join(upload_folder, filename)
+                file.save(filepath)
+                db_filename = 'clips/' + filename
+
+        elif action == 'drive_link':
+            link = request.form.get('link', '').strip()
+            media_type = request.form.get('media_type', 'audio')
             try:
                 file_id = extract_drive_id(link)
-                if media_type == 'video':
-                    db_filename = f"https://drive.google.com/uc?export=download&id={file_id}.mp4"
-                else:
-                    db_filename = f"https://drive.google.com/uc?export=download&id={file_id}.mp3"
-            except:
-                message = "Invalid Google Drive link."
-        else:
-            message = "Please upload a file or provide a valid Drive link."
+                # Manually add extension to help with player detection
+                ext = '.mp4' if media_type == 'video' else '.mp3'
+                db_filename = f"https://drive.google.com/uc?export=download&id={file_id}{ext}"
+            except Exception as e:
+                message = f"Invalid Google Drive link. ({e})"
 
-        # Save to DB if filename was set
+        # Insert into DB
         if db_filename:
             try:
                 with sqlite3.connect(DB_NAME) as conn:
@@ -459,10 +460,10 @@ def public_clips():
                     )
                     conn.commit()
                 message = "Clip added!"
-            except sqlite3.OperationalError:
-                message = "Database table not ready. Use SQL tool to create it first!"
+            except Exception as e:
+                message = "Error saving to database: " + str(e)
 
-    # Get clips (or show empty list if table missing)
+    # Fetch all clips
     try:
         with sqlite3.connect(DB_NAME) as conn:
             c = conn.cursor()
@@ -476,19 +477,6 @@ def public_clips():
 
     return render_template('clips.html', clips=clips, admin=admin, message=message)
 
-    # Get clips (or show empty list if table missing)
-    try:
-        with sqlite3.connect(DB_NAME) as conn:
-            c = conn.cursor()
-            c.execute("SELECT id, filename, title, description FROM music_clips")
-            # Always fix: use forward slashes in filename
-            clips = [
-                (id, filename.replace('\\', '/'), title, description)
-                for (id, filename, title, description) in c.fetchall()
-            ]
-    except sqlite3.OperationalError:
-        clips = []
-    return render_template('clips.html', clips=clips, admin=admin, message=message)
 
 @app.route('/dataset/<table>')
 def public_view(table):