validate YAML in test-charts.yml, beautify worflow YAMLs, update Helm to 4.1.0

Author: DanielRaapDev

.github/workflows/release-chart.yml

@@ -2,8 +2,10 @@ name: Release Charts
 
 on:
   workflow_run:
-    workflows: [ "Test Charts" ]
-    branches: [ main ]
+    workflows:
+      - Test Charts
+    branches:
+      - main
     types:
       - completed
 
@@ -27,4 +29,4 @@ jobs:
       - name: Run chart-releaser
         uses: helm/chart-releaser-action@v1.6.0
         env:
-          CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
+          CR_TOKEN: '${{ secrets.GITHUB_TOKEN }}'

.github/workflows/test-charts.yml

@@ -1,6 +1,8 @@
 name: Test Charts
 
-on: ["push", "pull_request"]
+on:
+  - push
+  - pull_request
 
 jobs:
   test:
@@ -10,7 +12,16 @@ jobs:
         uses: actions/checkout@v2
         with:
           fetch-depth: 0
+
       - name: Test Chart
-        uses: d3adb5/helm-unittest-action@v2
+        uses: d3adb5/helm-unittest-action@v2.5.0
         with:
-          helm-version: 'v3.11.2'
+          helm-version: v4.1.0
+
+      # validate YAML files with JSON schema
+      - name: Install the JSON Schema CLI
+        uses: sourcemeta/jsonschema@v14.7.0
+      - name: validate every Chart.yaml
+        run: |-
+          allCharts=$(find charts/ -name Chart.yaml -printf '%p ')
+          jsonschema validate chart-schema.json ${allCharts} --http