Skip to content

feat(isthmus) support calcite 1.39.0 #997

feat(isthmus) support calcite 1.39.0

feat(isthmus) support calcite 1.39.0 #997

Triggered via pull request March 31, 2025 08:36
Status Failure
Total duration 2m 27s
Artifacts 1

pr.yml

on: pull_request
Build and Test Java
2m 23s
Build and Test Java
Check editorconfig
5s
Check editorconfig
Lint commits for semantic-release
17s
Lint commits for semantic-release
Security validation
5s
Security validation
Build Examples
1m 46s
Build Examples
Dry-run release
16s
Dry-run release
Matrix: Build Isthmus Native Image
Matrix: osv-scanner
Fit to window
Zoom out
Zoom in

Annotations

4 errors
Check editorconfig
Process completed with exit code 1.
Lint commits for semantic-release
Process completed with exit code 1.
Build and Test Java
Process completed with exit code 1.
Build and Test Java: task ':isthmus:spotlessJavaCheck'#L0
Execution failed for task ':isthmus:spotlessJavaCheck': The following files had format violations: src/main/java/io/substrait/isthmus/SubstraitCalciteSchema.java @@ -1,5 +1,11 @@ package·io.substrait.isthmus; +import·com.google.common.collect.ImmutableSet; +import·io.substrait.isthmus.SqlConverterBase.DefinedTable; +import·io.substrait.relation.NamedScan; +import·io.substrait.relation.Rel; +import·io.substrait.relation.RelCopyOnWriteVisitor; +import·io.substrait.type.NamedStruct; import·java.util.ArrayList; import·java.util.HashMap; import·java.util.List; @@ -8,7 +14,6 @@ import·java.util.Set; import·java.util.function.Function; import·java.util.stream.Collectors; - import·org.apache.calcite.jdbc.CalciteSchema; import·org.apache.calcite.rel.type.RelDataTypeFactory; import·org.apache.calcite.schema.Schema; @@ -19,37 +24,26 @@ import·org.apache.calcite.schema.lookup.Named; import·org.checkerframework.checker.nullness.qual.Nullable; -import·com.google.common.collect.ImmutableSet; - -import·io.substrait.isthmus.SqlConverterBase.DefinedTable; -import·io.substrait.relation.NamedScan; -import·io.substrait.relation.Rel; -import·io.substrait.relation.RelCopyOnWriteVisitor; -import·io.substrait.type.NamedStruct; - /** ·*·A·subclass·of·the·Calcite·Schema·for·creation·from·a·Substrait·relation ·* -·*·Implementation·note: +·*·<p>Implementation·note: ·* -·*·The·external·Isthmus·API·can·take·a·function·that·will·return·the·table -·*·schema·when·needed,·rather·than·it·being·available·up·front. -·* -·*·This·was·implemented·by·a·special·subclass·of·the·Calcite·simple·schena. -·*·Since·this·was·changed·in·Caclite·1.39.0;·it·failed·to·work;·the·protected -·*·methods·it·extended·from·change. +·*·<p>The·external·Isthmus·API·can·take·a·function·that·will·return·the·table·schema·when·needed, +·*·rather·than·it·being·available·up·front. ·* -·*·The·change,·ironically,·was·support·a·laxy·approach·to·looking·up -·*·Calcite·schemas.·Good·-·*but*·the·external·function·in·Isthmus·is·assuming ... (116 more lines that didn't fit) Violations also present in: src/main/java/io/substrait/isthmus/SubstraitToCalcite.java src/test/java/io/substrait/isthmus/api/ExampleCalciteReflectiveSchema.java src/test/java/io/substrait/isthmus/api/TestIsthmusEndToEnd.java Run './gradlew :isthmus:spotlessApply' to fix these violations. at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:111) at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:53) at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:125) at org.gradle.api.internal.project.taskfactory.StandardTaskAction.doExecute(StandardTaskAction.java:58) at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:51) at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:29) at org.gradle.api.internal.tasks.execution.TaskExecution$3.run(TaskExecution.java:244) at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:30) at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:27) at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:67) at org.gradle.internal.operations.DefaultBuildOperationRunner$2.e

Artifacts

Produced during runtime
Name Size Digest
cyclonedx-sbom Expired
66.4 KB
sha256:b673de76f998fcfb24f290e75ffcd395b2eab4c5843acb9ed486e0e2de842bf3