feat(isthmus): mapping of factorial function from substrait (#589)

Author: asuriy

isthmus/src/main/java/io/substrait/isthmus/calcite/SubstraitOperatorTable.java

@@ -46,7 +46,8 @@ public class SubstraitOperatorTable implements SqlOperatorTable {
   // Utilisation of extended library operators available from calcite 1.35+, i.e hyperbolic
   // functions
   private static final SqlOperatorTable LIBRARY_OPERATOR_TABLE =
-      SqlLibraryOperatorTableFactory.INSTANCE.getOperatorTable(SqlLibrary.ALL);
+      SqlLibraryOperatorTableFactory.INSTANCE.getOperatorTable(
+          EnumSet.of(SqlLibrary.HIVE, SqlLibrary.SPARK, SqlLibrary.ALL));
 
   private static final SqlOperatorTable STANDARD_OPERATOR_TABLE = SqlStdOperatorTable.instance();
 

isthmus/src/main/java/io/substrait/isthmus/expression/FunctionMappings.java

@@ -77,7 +77,8 @@ public class FunctionMappings {
               s(SqlStdOperatorTable.BITAND, "bitwise_and"),
               s(SqlStdOperatorTable.BITXOR, "bitwise_xor"),
               s(SqlStdOperatorTable.RADIANS, "radians"),
-              s(SqlStdOperatorTable.DEGREES, "degrees"))
+              s(SqlStdOperatorTable.DEGREES, "degrees"),
+              s(SqlLibraryOperators.FACTORIAL, "factorial"))
           .build();
 
   public static final ImmutableList<Sig> AGGREGATE_SIGS =

isthmus/src/test/java/io/substrait/isthmus/ArithmeticFunctionTest.java

@@ -199,4 +199,11 @@ void degrees(String column) throws Exception {
     String query = String.format("SELECT DEGREES(%s) FROM numbers", column);
     assertFullRoundTrip(query, CREATES);
   }
+
+  @ParameterizedTest
+  @ValueSource(strings = {"i32", "i64"})
+  void factorial(String column) throws Exception {
+    String query = String.format("SELECT FACTORIAL(%s) FROM numbers", column);
+    assertFullRoundTrip(query, CREATES);
+  }
 }