refactor: revert to simpler binary construction for any rep UDT in calcite

benbellick · benbellick · commit ce7985fcade4 · 2025-11-24T16:51:01.000-05:00
diff --git a/isthmus/src/main/java/io/substrait/isthmus/expression/ExpressionRexConverter.java b/isthmus/src/main/java/io/substrait/isthmus/expression/ExpressionRexConverter.java
@@ -112,7 +112,7 @@ public RexNode visit(Expression.NullLiteral expr, Context context) throws Runtim
   public RexNode visit(Expression.UserDefinedAnyLiteral expr, Context context)
       throws RuntimeException {
     RexLiteral binaryLiteral =
-        rexBuilder.makeBinaryLiteral(new ByteString(expr.value().toByteString().toByteArray()));
+        rexBuilder.makeBinaryLiteral(new ByteString(expr.value().toByteArray()));
     RelDataType type = typeConverter.toCalcite(typeFactory, expr.getType());
     return rexBuilder.makeReinterpretCast(type, binaryLiteral, rexBuilder.makeLiteral(false));
   }

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ public RexNode visit(Expression.NullLiteral expr, Context context) throws Runtim`
`112`	`112`	`public RexNode visit(Expression.UserDefinedAnyLiteral expr, Context context)`
`113`	`113`	`throws RuntimeException {`
`114`	`114`	`RexLiteral binaryLiteral =`
`115`		`- rexBuilder.makeBinaryLiteral(new ByteString(expr.value().toByteString().toByteArray()));`
	`115`	`+ rexBuilder.makeBinaryLiteral(new ByteString(expr.value().toByteArray()));`
`116`	`116`	`RelDataType type = typeConverter.toCalcite(typeFactory, expr.getType());`
`117`	`117`	`return rexBuilder.makeReinterpretCast(type, binaryLiteral, rexBuilder.makeLiteral(false));`
`118`	`118`	`}`