Skip to content

Commit d8b9dbc

Browse files
committed
fix: handle valid YAML extension types
Closes #594
1 parent cce51cd commit d8b9dbc

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

core/src/main/java/io/substrait/extension/SimpleExtension.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -535,12 +535,19 @@ public abstract static class Type {
535535

536536
public abstract String name();
537537

538+
public abstract Optional<String> description();
539+
538540
@JacksonInject(SimpleExtension.URN_LOCATOR_KEY)
539541
public abstract String urn();
540542

541543
// TODO: Handle conversion of structure object to Named Struct representation
542544
protected abstract Optional<Object> structure();
543545

546+
// TODO: Properly handle parameters
547+
protected abstract Optional<List<Object>> parameters();
548+
549+
protected abstract Optional<Boolean> variadic();
550+
544551
public TypeAnchor getAnchor() {
545552
return anchorSupplier.get();
546553
}

core/src/test/resources/extensions/custom_extensions.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
urn: extension:test:custom_extensions
44
types:
55
- name: "customType1"
6+
description: >-
7+
some description
8+
variadic: true
9+
parameters: []
610
- name: "customType2"
711
structure:
812
field1: i32

0 commit comments

Comments
 (0)