build: use nmcp instead of jreleaser (#547)

There are two issues with JReleaser:

1. It is a heavy weight plugin designed to manage the entire release
   process, similar to semantic-release, and it is only used for
   publishing to the Maven Central Publisher API.
2. Transitive dependency conflicts between Spotless 8.x and JRelease 1.x
   plugins prevent them being used together.

This change replaces JReleaser with the GradleUp nmcp (New Maven Central
Publishing) plugin. This is a much lighter weight plugin that only
provides capability to publish to Maven Central.

This change also updates Spotless to 8.0.0 since conflicts with
JReleaser no longer occur.

Signed-off-by: Mark S. Lewis <[email protected]>

Author: bestbeforetoday

.github/workflows/release.yml

@@ -101,5 +101,5 @@ jobs:
           SIGNING_KEY_ID: ${{ secrets.SIGNING_KEY_ID }}
           SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }}
           SIGNING_KEY: ${{ secrets.SIGNING_KEY }}
-          JRELEASER_MAVENCENTRAL_USERNAME: ${{ secrets.MAVEN_CENTRAL_USER }}
-          JRELEASER_MAVENCENTRAL_PASSWORD: ${{ secrets.MAVEN_CENTRAL_KEY }}
+          MAVENCENTRAL_USERNAME: ${{ secrets.MAVEN_CENTRAL_USER }}
+          MAVENCENTRAL_PASSWORD: ${{ secrets.MAVEN_CENTRAL_KEY }}

build.gradle.kts

@@ -9,20 +9,37 @@ plugins {
   id("idea")
   alias(libs.plugins.gradle.extensions)
   alias(libs.plugins.spotless)
-  alias(libs.plugins.jreleaser) apply false
+  alias(libs.plugins.nmcp).apply(false)
+  alias(libs.plugins.nmcp.aggregation)
 }
 
 repositories { mavenCentral() }
 
 java { toolchain { languageVersion.set(JavaLanguageVersion.of(17)) } }
 
+nmcpAggregation {
+  centralPortal {
+    username =
+      System.getenv("MAVENCENTRAL_USERNAME").takeUnless { it.isNullOrEmpty() }
+        ?: extra["MAVENCENTRAL_USERNAME"].toString()
+    password =
+      System.getenv("MAVENCENTRAL_PASSWORD").takeUnless { it.isNullOrEmpty() }
+        ?: extra["MAVENCENTRAL_PASSWORD"].toString()
+    publishingType = "AUTOMATIC"
+  }
+}
+
 dependencies {
   testImplementation(platform(libs.junit.bom))
   testImplementation(libs.junit.jupiter.api)
   testImplementation(libs.junit.jupiter.engine)
   implementation(libs.slf4j.api)
   annotationProcessor(libs.immutables.value)
   compileOnly(libs.immutables.annotations)
+
+  nmcpAggregation(project(":core"))
+  nmcpAggregation(project(":spark"))
+  nmcpAggregation(project(":isthmus"))
 }
 
 allprojects {
@@ -44,7 +61,7 @@ allprojects {
         googleJavaFormat()
         removeUnusedImports()
         trimTrailingWhitespace()
-        removeWildcardImports()
+        forbidWildcardImports()
       }
     }
   }

ci/release/publish.sh

@@ -7,5 +7,4 @@ set -euo pipefail
 git submodule foreach 'git fetch --unshallow || true'
 
 ./gradlew clean
-./gradlew publishAllPublicationsToStagingRepository
-./gradlew jreleaserDeploy
+./gradlew publishAggregationToCentralPortal

ci/release/sanity.sh

@@ -5,7 +5,7 @@ set -euo pipefail
 export GPG_TTY=$(tty)
 
 echo "Validate Central Publisher API credentials."
-BEARER=$(printf "%s:%s" "${SONATYPE_USER}" "${SONATYPE_PASSWORD}" | base64)
+BEARER=$(printf "%s:%s" "${MAVENCENTRAL_USERNAME}" "${MAVENCENTRAL_PASSWORD}" | base64)
 CODE=$(curl --request GET 'https://central.sonatype.com/api/v1/publisher/published?namespace=io.substrait&name=core&version=0.1.0' --header 'accept: application/json' --header "Authorization: Bearer ${BEARER}" -sSL -w '%{http_code}' -o /dev/null)
 if [[ "$CODE" =~ ^2 ]]; then
     echo "Central Publisher API credentials configured successfully."

core/build.gradle.kts

@@ -1,7 +1,5 @@
 import java.io.ByteArrayOutputStream
 import java.nio.charset.StandardCharsets
-import org.gradle.api.provider.ValueSource
-import org.gradle.api.provider.ValueSourceParameters
 import org.gradle.plugins.ide.idea.model.IdeaModel
 import org.slf4j.LoggerFactory
 
@@ -14,7 +12,7 @@ plugins {
   alias(libs.plugins.protobuf)
   alias(libs.plugins.spotless)
   alias(libs.plugins.shadow)
-  alias(libs.plugins.jreleaser)
+  alias(libs.plugins.nmcp)
   id("substrait.java-conventions")
 }
 
@@ -58,16 +56,12 @@ publishing {
       val snapshotsRepoUrl = layout.buildDirectory.dir("repos/snapshots")
       url = uri(if (version.toString().endsWith("SNAPSHOT")) snapshotsRepoUrl else releasesRepoUrl)
     }
-    maven {
-      name = "staging"
-      url = stagingRepositoryUrl
-    }
   }
 }
 
 signing {
   setRequired({
-    gradle.taskGraph.hasTask(":${project.name}:publishMaven-publishPublicationToStagingRepository")
+    gradle.taskGraph.hasTask(":${project.name}:publishMaven-publishPublicationToNmcpRepository")
   })
   val signingKeyId =
     System.getenv("SIGNING_KEY_ID").takeUnless { it.isNullOrEmpty() }
@@ -82,23 +76,6 @@ signing {
   sign(publishing.publications["maven-publish"])
 }
 
-jreleaser {
-  gitRootSearch = true
-  deploy {
-    maven {
-      mavenCentral {
-        register("sonatype") {
-          active = org.jreleaser.model.Active.ALWAYS
-          url = "https://central.sonatype.com/api/v1/publisher"
-          sign = false
-          stagingRepository(file(stagingRepositoryUrl).toString())
-        }
-      }
-    }
-  }
-  release { github { enabled = false } }
-}
-
 // This allows specifying deps to be shadowed so that they don't get included in the POM file
 val shadowImplementation by configurations.creating
 

gradle.properties

@@ -16,5 +16,5 @@ SIGNING_PASSWORD = password
 SIGNING_KEY = ALDqwcArqwfsdqweqwrwr
 
 #sonatype credentials
-SONATYPE_USER = admin
-SONATYPE_PASSWORD = password
+MAVENCENTRAL_USERNAME = admin
+MAVENCENTRAL_PASSWORD = password

gradle/libs.versions.toml

@@ -10,10 +10,10 @@ guava = "33.5.0-jre"
 httpclient5 = "5.5.1"
 immutables = "2.11.4"
 jackson = "2.20.0"
-jreleaser = "1.20.0"
 json-smart = "2.6.0"
 jspecify = "1.0.0"
 junit = "5.13.4"
+nmcp = "1.2.0"
 picocli = "4.7.7"
 protobuf-plugin = "0.9.5"
 protobuf = "3.25.8"
@@ -23,7 +23,7 @@ scalatestplus-junit5 = "3.2.19.0"
 shadow = "9.2.2"
 slf4j = "2.0.17"
 spark = "3.4.4"
-spotless = "7.2.1"
+spotless = "8.0.0"
 
 [libraries]
 antlr4 = { module = "org.antlr:antlr4", version.ref = "antlr" }
@@ -73,7 +73,8 @@ jackson = [ "jackson-databind", "jackson-annotations", "jackson-datatype-jdk8",
 [plugins]
 graal = { id = "org.graalvm.buildtools.native", version.ref = "graal-plugin" }
 gradle-extensions = { id = "com.github.vlsi.gradle-extensions", version.ref = "gradle-extensions" }
-jreleaser = { id = "org.jreleaser", version.ref = "jreleaser" }
+nmcp = { id = "com.gradleup.nmcp", version.ref = "nmcp" }
+nmcp-aggregation = { id = "com.gradleup.nmcp.aggregation", version.ref = "nmcp" }
 protobuf = { id = "com.google.protobuf", version.ref = "protobuf-plugin" }
 shadow = { id = "com.gradleup.shadow", version.ref = "shadow" }
 spotless = { id = "com.diffplug.spotless", version.ref = "spotless" }

isthmus/build.gradle.kts

@@ -8,7 +8,7 @@ plugins {
   alias(libs.plugins.shadow)
   alias(libs.plugins.spotless)
   alias(libs.plugins.protobuf)
-  alias(libs.plugins.jreleaser)
+  alias(libs.plugins.nmcp)
   id("substrait.java-conventions")
 }
 
@@ -52,16 +52,12 @@ publishing {
       val snapshotsRepoUrl = layout.buildDirectory.dir("repos/snapshots")
       url = uri(if (version.toString().endsWith("SNAPSHOT")) snapshotsRepoUrl else releasesRepoUrl)
     }
-    maven {
-      name = "staging"
-      url = stagingRepositoryUrl
-    }
   }
 }
 
 signing {
   setRequired({
-    gradle.taskGraph.hasTask(":${project.name}:publishMaven-publishPublicationToStagingRepository")
+    gradle.taskGraph.hasTask(":${project.name}:publishMaven-publishPublicationToNmcpRepository")
   })
   val signingKeyId =
     System.getenv("SIGNING_KEY_ID").takeUnless { it.isNullOrEmpty() }
@@ -76,23 +72,6 @@ signing {
   sign(publishing.publications["maven-publish"])
 }
 
-jreleaser {
-  gitRootSearch = true
-  deploy {
-    maven {
-      mavenCentral {
-        register("sonatype") {
-          active = org.jreleaser.model.Active.ALWAYS
-          url = "https://central.sonatype.com/api/v1/publisher"
-          sign = false
-          stagingRepository(file(stagingRepositoryUrl).toString())
-        }
-      }
-    }
-  }
-  release { github { enabled = false } }
-}
-
 java {
   toolchain { languageVersion = JavaLanguageVersion.of(11) }
   withJavadocJar()

spark/build.gradle.kts

@@ -5,7 +5,7 @@ plugins {
   id("scala")
   id("idea")
   alias(libs.plugins.spotless)
-  alias(libs.plugins.jreleaser)
+  alias(libs.plugins.nmcp)
   id("substrait.java-conventions")
 }
 
@@ -49,16 +49,12 @@ publishing {
       val snapshotsRepoUrl = layout.buildDirectory.dir("repos/snapshots")
       url = uri(if (version.toString().endsWith("SNAPSHOT")) snapshotsRepoUrl else releasesRepoUrl)
     }
-    maven {
-      name = "staging"
-      url = stagingRepositoryUrl
-    }
   }
 }
 
 signing {
   setRequired({
-    gradle.taskGraph.hasTask(":${project.name}:publishMaven-publishPublicationToStagingRepository")
+    gradle.taskGraph.hasTask(":${project.name}:publishMaven-publishPublicationToNmcpRepository")
   })
   val signingKeyId =
     System.getenv("SIGNING_KEY_ID").takeUnless { it.isNullOrEmpty() }
@@ -73,23 +69,6 @@ signing {
   sign(publishing.publications["maven-publish"])
 }
 
-jreleaser {
-  gitRootSearch = true
-  deploy {
-    maven {
-      mavenCentral {
-        register("sonatype") {
-          active = org.jreleaser.model.Active.ALWAYS
-          url = "https://central.sonatype.com/api/v1/publisher"
-          sign = false
-          stagingRepository(file(stagingRepositoryUrl).toString())
-        }
-      }
-    }
-  }
-  release { github { enabled = false } }
-}
-
 configurations.all {
   if (name.startsWith("incrementalScalaAnalysis")) {
     setExtendsFrom(emptyList())