fix: update ANTLR setup

Author: giospada

.devcontainer/Dockerfile

@@ -5,6 +5,7 @@ RUN bash -c "source $HOME/.sdkman/bin/sdkman-init.sh && \
     sdk install java 25-graalce"
 COPY scripts/setup_antlr.sh /tmp/setup_antlr.sh
 RUN bash /tmp/setup_antlr.sh && rm /tmp/setup_antlr.sh
+ENV ANTLR_JAR="lib/antlr-complete.jar"
 # protoc 29.5 is the last version with protobuf python v5 which is compatible with protoletariat v3
 RUN cd ~ && curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v29.5/protoc-29.5-linux-x86_64.zip && \
     unzip protoc-29.5-linux-x86_64.zip -d ~/.local && \

CONTRIBUTING.md

@@ -28,7 +28,7 @@ Run the upgrade script to upgrade the submodule and regenerate the protobuf stub
 
 ```
 uv sync --extra gen_proto
-uv run ./update_proto.sh <version>
+uv run scripts/update_proto.sh <version>
 ```
 
 ## Antlr grammar

Makefile

@@ -1,10 +1,9 @@
 setup-antlr:
 	@bash scripts/setup_antlr.sh > /dev/null
 
-antlr:
-	@export ANTLR_JAR=$$(bash scripts/setup_antlr.sh); \
+antlr: setup-antlr
 	cd third_party/substrait/grammar \
-		&& java -jar ../../../$${ANTLR_JAR} -o ../../../src/substrait/gen/antlr -Dlanguage=Python3 SubstraitType.g4 \
+		&& java -jar ../../../lib/antlr-complete.jar -o ../../../src/substrait/gen/antlr -Dlanguage=Python3 SubstraitType.g4 \
 		&& rm ../../../src/substrait/gen/antlr/*.tokens \
 		&& rm ../../../src/substrait/gen/antlr/*.interp
 

scripts/setup_antlr.sh

@@ -5,7 +5,7 @@ set -e
 
 ANTLR_VERSION="4.13.2"
 ANTLR_JAR_DIR="lib"
-ANTLR_JAR="${ANTLR_JAR_DIR}/antlr-${ANTLR_VERSION}-complete.jar"
+ANTLR_JAR="${ANTLR_JAR_DIR}/antlr-complete.jar"
 ANTLR_URL="http://www.antlr.org/download/antlr-${ANTLR_VERSION}-complete.jar"
 VERSION_FILE="${ANTLR_JAR_DIR}/.antlr_version"