Remove the rfcomm filter function

The rfcomm filter function is not only platform dependent (Linux only),
but also difficult to use correctly. It should only be enabled for
devices which support DC_TRANSPORT_SERIAL due to the serial port
emulation layer of the bluetooth Serial Port Profile (SPP/rfcomm), and
not for usb-serial communication. However, some dive computers models
like the OSTC3 have both rfcomm and usb-serial enabled variants. Since
the filter functions are shared by all models, the result isn't always
reliable.

Fixed by simply removing the rfcomm filter. For serial communication,
every string will now be considered a match, which is the same result as
with no filter function present.

Author: jefdriesen

src/descriptor.c

@@ -521,15 +521,6 @@ dc_match_prefix (const void *key, const void *value)
 	return strncasecmp (k, v, strlen (v)) == 0;
 }
 
-static int
-dc_match_devname (const void *key, const void *value)
-{
-	const char *k = (const char *) key;
-	const char *v = *(const char * const *) value;
-
-	return strncmp (k, v, strlen (v)) == 0;
-}
-
 static int
 dc_match_usb (const void *key, const void *value)
 {
@@ -641,13 +632,6 @@ dc_filter_internal (const void *key, const void *values, size_t count, size_t si
 	return count == 0;
 }
 
-static const char * const rfcomm[] = {
-#if defined (__linux__)
-	"/dev/rfcomm",
-#endif
-	NULL
-};
-
 static int
 dc_filter_uwatec (const dc_descriptor_t *descriptor, dc_transport_t transport, const void *userdata)
 {
@@ -724,8 +708,6 @@ dc_filter_hw (const dc_descriptor_t *descriptor, dc_transport_t transport, const
 
 	if (transport == DC_TRANSPORT_BLUETOOTH || transport == DC_TRANSPORT_BLE) {
 		return DC_FILTER_INTERNAL (userdata, bluetooth, 0, dc_match_prefix);
-	} else if (transport == DC_TRANSPORT_SERIAL) {
-		return DC_FILTER_INTERNAL (userdata, rfcomm, 1, dc_match_devname);
 	}
 
 	return 1;
@@ -750,8 +732,6 @@ dc_filter_shearwater (const dc_descriptor_t *descriptor, dc_transport_t transpor
 
 	if (transport == DC_TRANSPORT_BLUETOOTH || transport == DC_TRANSPORT_BLE) {
 		return DC_FILTER_INTERNAL (userdata, bluetooth, 0, dc_match_name);
-	} else if (transport == DC_TRANSPORT_SERIAL) {
-		return DC_FILTER_INTERNAL (userdata, rfcomm, 1, dc_match_devname);
 	}
 
 	return 1;
@@ -766,8 +746,6 @@ dc_filter_tecdiving (const dc_descriptor_t *descriptor, dc_transport_t transport
 
 	if (transport == DC_TRANSPORT_BLUETOOTH) {
 		return DC_FILTER_INTERNAL (userdata, bluetooth, 0, dc_match_name);
-	} else if (transport == DC_TRANSPORT_SERIAL) {
-		return DC_FILTER_INTERNAL (userdata, rfcomm, 1, dc_match_devname);
 	}
 
 	return 1;
@@ -847,8 +825,6 @@ dc_filter_mclean(const dc_descriptor_t *descriptor, dc_transport_t transport, co
 
 	if (transport == DC_TRANSPORT_BLUETOOTH || transport == DC_TRANSPORT_BLE) {
 		return DC_FILTER_INTERNAL (userdata, bluetooth, 0, dc_match_name);
-	} else if (transport == DC_TRANSPORT_SERIAL) {
-		return DC_FILTER_INTERNAL(userdata, rfcomm, 1, dc_match_devname);
 	}
 
 	return 1;