Add extra debug information to the log

jefdriesen · mikeller · commit eae0fa2d522e · 2025-06-08T15:29:05.000+12:00
diff --git a/src/atomics_cobalt.c b/src/atomics_cobalt.c
@@ -105,6 +105,8 @@ atomics_cobalt_device_open (dc_device_t **out, dc_context_t *context, dc_iostrea
 		goto error_free;
 	}
 
+	HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Version", device->version, sizeof (device->version));
+
 	*out = (dc_device_t*) device;
 
 	return DC_STATUS_SUCCESS;
diff --git a/src/cressi_edy.c b/src/cressi_edy.c
@@ -204,6 +204,8 @@ cressi_edy_init2 (cressi_edy_device_t *device)
 	if (rc != DC_STATUS_SUCCESS)
 		return rc;
 
+	HEXDUMP (device->base.context, DC_LOGLEVEL_DEBUG, "Model", answer, sizeof (answer));
+
 	device->model = answer[0];
 
 	return DC_STATUS_SUCCESS;
diff --git a/src/cressi_goa.c b/src/cressi_goa.c
@@ -522,6 +522,8 @@ cressi_goa_device_foreach (dc_device_t *abstract, dc_dive_callback_t callback, v
 	const unsigned char *id_data = dc_buffer_get_data(id);
 	size_t id_size = dc_buffer_get_size(id);
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Version", id_data, id_size);
+
 	if (id_size < 9) {
 		ERROR (abstract->context, "Unexpected version length (" DC_PRINTF_SIZE ").", id_size);
 		status = DC_STATUS_DATAFORMAT;
diff --git a/src/deepblu_cosmiq.c b/src/deepblu_cosmiq.c
@@ -391,6 +391,8 @@ deepblu_cosmiq_device_foreach (dc_device_t *abstract, dc_dive_callback_t callbac
 		goto error_exit;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Firmware", fw, sizeof(fw));
+
 	// Read the MAC address.
 	unsigned char mac[6] = {0};
 	status = deepblu_cosmiq_transfer (device, CMD_SYSTEM_MAC, &zero, 1, mac, sizeof(mac));
@@ -399,6 +401,8 @@ deepblu_cosmiq_device_foreach (dc_device_t *abstract, dc_dive_callback_t callbac
 		goto error_exit;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Serial", mac, sizeof(mac));
+
 	// Emit a device info event.
 	dc_event_devinfo_t devinfo;
 	devinfo.model = 0;
diff --git a/src/deepsix_excursion.c b/src/deepsix_excursion.c
@@ -283,6 +283,8 @@ deepsix_excursion_device_foreach (dc_device_t *abstract, dc_dive_callback_t call
 		return status;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Hardware", rsp_hardware, sizeof(rsp_hardware));
+
 	// Read the software version.
 	unsigned char rsp_software[6] = {0};
 	status = deepsix_excursion_transfer (device, GRP_INFO, CMD_INFO_SOFTWARE, DIR_READ, NULL, 0, rsp_software, sizeof(rsp_software), NULL);
@@ -291,6 +293,8 @@ deepsix_excursion_device_foreach (dc_device_t *abstract, dc_dive_callback_t call
 		return status;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Software", rsp_software, sizeof(rsp_software));
+
 	// Read the serial number
 	unsigned char rsp_serial[12] = {0};
 	status = deepsix_excursion_transfer (device, GRP_INFO, CMD_INFO_SERIAL, DIR_READ, NULL, 0, rsp_serial, sizeof(rsp_serial), NULL);
@@ -299,6 +303,8 @@ deepsix_excursion_device_foreach (dc_device_t *abstract, dc_dive_callback_t call
 		return status;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Serial", rsp_serial, sizeof(rsp_serial));
+
 	// Emit a device info event.
 	dc_event_devinfo_t devinfo;
 	devinfo.model = 0;
diff --git a/src/diverite_nitekq.c b/src/diverite_nitekq.c
@@ -191,6 +191,8 @@ diverite_nitekq_device_open (dc_device_t **out, dc_context_t *context, dc_iostre
 		goto error_free;
 	}
 
+	HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Version", device->version, sizeof (device->version));
+
 	*out = (dc_device_t*) device;
 
 	return DC_STATUS_SUCCESS;
diff --git a/src/divesoft_freedom.c b/src/divesoft_freedom.c
@@ -344,6 +344,8 @@ divesoft_freedom_device_open (dc_device_t **out, dc_context_t *context, dc_iostr
 		goto error_free_hdlc;
 	}
 
+	HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Connection", rsp_connect, sizeof(rsp_connect));
+
 	DEBUG (context, "Connection: compression=%u, protocol=%u.%u, serial=%.16s",
 		array_uint16_le (rsp_connect),
 		rsp_connect[2], rsp_connect[3],
@@ -402,6 +404,8 @@ divesoft_freedom_device_foreach (dc_device_t *abstract, dc_dive_callback_t callb
 		goto error_exit;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Version", rsp_version, sizeof(rsp_version));
+
 	DEBUG (abstract->context, "Device: model=%u, hw=%u.%u, sw=%u.%u.%u.%u serial=%.16s",
 		rsp_version[0],
 		rsp_version[1], rsp_version[2],
diff --git a/src/divesystem_idive.c b/src/divesystem_idive.c
@@ -453,6 +453,8 @@ divesystem_idive_device_foreach (dc_device_t *abstract, dc_dive_callback_t callb
 	if (rc != DC_STATUS_SUCCESS)
 		return rc;
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Version", packet, commands->id.size);
+
 	// Emit a device info event.
 	dc_event_devinfo_t devinfo;
 	devinfo.model = array_uint16_le (packet);
diff --git a/src/halcyon_symbios.c b/src/halcyon_symbios.c
@@ -445,6 +445,8 @@ halcyon_symbios_device_foreach (dc_device_t *abstract, dc_dive_callback_t callba
 		goto error_exit;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Version", info, sizeof(info));
+
 	// Emit a vendor event.
 	dc_event_vendor_t vendor;
 	vendor.data = info;
@@ -494,6 +496,8 @@ halcyon_symbios_device_foreach (dc_device_t *abstract, dc_dive_callback_t callba
 	const unsigned char *data = dc_buffer_get_data (logbook);
 	size_t size = dc_buffer_get_size (logbook);
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Logbook", data, size);
+
 	// Get the number of dives.
 	unsigned int ndives = 0;
 	unsigned int offset = size;
diff --git a/src/hw_frog.c b/src/hw_frog.c
@@ -326,6 +326,8 @@ hw_frog_device_foreach (dc_device_t *abstract, dc_dive_callback_t callback, void
 		return rc;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Version", id, sizeof (id));
+
 	// Emit a device info event.
 	dc_event_devinfo_t devinfo;
 	devinfo.model = 0;
diff --git a/src/hw_ostc3.c b/src/hw_ostc3.c
@@ -612,6 +612,8 @@ hw_ostc3_device_init (hw_ostc3_device_t *device, hw_ostc3_state_t state)
 		return rc;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Hardware", hardware, sizeof(hardware));
+
 	// Read the version information.
 	unsigned char version[SZ_VERSION] = {0};
 	rc = hw_ostc3_transfer (device, NULL, IDENTITY, NULL, 0, version, sizeof(version), NULL, NODELAY);
@@ -620,6 +622,8 @@ hw_ostc3_device_init (hw_ostc3_device_t *device, hw_ostc3_state_t state)
 		return rc;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Version", version, sizeof(version));
+
 	// Cache the descriptor.
 	device->hardware = array_uint16_be(hardware + 0);
 	if (device->hardware != OSTC4) {
diff --git a/src/liquivision_lynx.c b/src/liquivision_lynx.c
@@ -284,6 +284,8 @@ liquivision_lynx_device_open (dc_device_t **out, dc_context_t *context, dc_iostr
 		goto error_free;
 	}
 
+	HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Info", device->info, sizeof(device->info));
+
 	// Send the more info command.
 	const unsigned char cmd_more[] = {0x4D, 0x4F, 0x52, 0x45, 0x49, 0x4E, 0x46, 0x4F, 0x4D, 0x4F, 0x52, 0x45};
 	status = liquivision_lynx_transfer (device, cmd_more, sizeof(cmd_more), device->more, sizeof(device->more));
@@ -292,6 +294,8 @@ liquivision_lynx_device_open (dc_device_t **out, dc_context_t *context, dc_iostr
 		goto error_free;
 	}
 
+	HEXDUMP (context, DC_LOGLEVEL_DEBUG, "More", device->more, sizeof(device->more));
+
 	*out = (dc_device_t *) device;
 
 	return DC_STATUS_SUCCESS;
diff --git a/src/mares_iconhd.c b/src/mares_iconhd.c
@@ -616,6 +616,8 @@ mares_iconhd_device_open (dc_device_t **out, dc_context_t *context, dc_iostream_
 		goto error_free_iostream;
 	}
 
+	HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Version", device->version, sizeof (device->version));
+
 	// Autodetect the model using the version packet.
 	device->model = mares_iconhd_get_model (device);
 
@@ -1047,6 +1049,8 @@ mares_iconhd_device_foreach_object (dc_device_t *abstract, dc_dive_callback_t ca
 		return rc;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Model", dc_buffer_get_data (buffer), dc_buffer_get_size (buffer));
+
 	if (dc_buffer_get_size (buffer) < 4) {
 		ERROR (abstract->context, "Unexpected number of bytes received (" DC_PRINTF_SIZE ").",
 			dc_buffer_get_size (buffer));
@@ -1067,6 +1071,8 @@ mares_iconhd_device_foreach_object (dc_device_t *abstract, dc_dive_callback_t ca
 		return rc;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Serial", dc_buffer_get_data (buffer), dc_buffer_get_size (buffer));
+
 	if (dc_buffer_get_size (buffer) < 16) {
 		ERROR (abstract->context, "Unexpected number of bytes received (" DC_PRINTF_SIZE ").",
 			dc_buffer_get_size (buffer));
diff --git a/src/mclean_extreme.c b/src/mclean_extreme.c
@@ -541,6 +541,8 @@ mclean_extreme_device_foreach(dc_device_t *abstract, dc_dive_callback_t callback
 		return status;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Firmware", firmware, sizeof(firmware));
+
 	// Read the serial number.
 	size_t serial_len = 0;
 	unsigned char serial[SZ_PACKET] = {0};
@@ -550,6 +552,8 @@ mclean_extreme_device_foreach(dc_device_t *abstract, dc_dive_callback_t callback
 		return status;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Serial", serial, serial_len);
+
 	// Emit a device info event.
 	dc_event_devinfo_t devinfo;
 	devinfo.model = 0;
@@ -565,6 +569,8 @@ mclean_extreme_device_foreach(dc_device_t *abstract, dc_dive_callback_t callback
 		return status;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Config", computer, sizeof(computer));
+
 	// Verify the format version.
 	unsigned int format = computer[0x0000];
 	if (format != 0) {
diff --git a/src/oceanic_atom2.c b/src/oceanic_atom2.c
@@ -948,6 +948,8 @@ oceanic_atom2_device_open (dc_device_t **out, dc_context_t *context, dc_iostream
 		goto error_free;
 	}
 
+	HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Version", device->base.version, sizeof (device->base.version));
+
 	if (dc_iostream_get_transport (device->iostream) == DC_TRANSPORT_BLE) {
 		status = oceanic_atom2_ble_handshake(device);
 		if (status != DC_STATUS_SUCCESS) {
diff --git a/src/oceanic_veo250.c b/src/oceanic_veo250.c
@@ -318,6 +318,8 @@ oceanic_veo250_device_open (dc_device_t **out, dc_context_t *context, dc_iostrea
 		goto error_free;
 	}
 
+	HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Version", device->base.version, sizeof (device->base.version));
+
 	// Detect the memory layout.
 	const oceanic_common_version_t *version = OCEANIC_COMMON_MATCH(device->base.version, versions, &device->base.firmware);
 	if (version == NULL) {
diff --git a/src/oceanic_vtpro.c b/src/oceanic_vtpro.c
@@ -526,6 +526,8 @@ oceanic_vtpro_device_open (dc_device_t **out, dc_context_t *context, dc_iostream
 		goto error_free;
 	}
 
+	HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Version", device->base.version, sizeof (device->base.version));
+
 	// Calibrate the device. Although calibration is optional, it's highly
 	// recommended because it reduces the transfer time considerably, even
 	// when processing the command itself is quite slow.
diff --git a/src/reefnet_sensus.c b/src/reefnet_sensus.c
@@ -219,6 +219,8 @@ reefnet_sensus_handshake (reefnet_sensus_device_t *device)
 		return DC_STATUS_PROTOCOL;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Handshake", handshake + 2, sizeof(handshake) - 2);
+
 	// The device is now waiting for a data request.
 	device->waiting = 1;
 
diff --git a/src/reefnet_sensuspro.c b/src/reefnet_sensuspro.c
@@ -183,6 +183,8 @@ reefnet_sensuspro_handshake (reefnet_sensuspro_device_t *device)
 		return DC_STATUS_PROTOCOL;
 	}
 
+	HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Handshake", handshake, SZ_HANDSHAKE);
+
 	// Store the clock calibration values.
 	device->systime = dc_datetime_now ();
 	device->devtime = array_uint32_le (handshake + 6);
diff --git a/src/reefnet_sensusultra.c b/src/reefnet_sensusultra.c
@@ -243,6 +243,8 @@ reefnet_sensusultra_handshake (reefnet_sensusultra_device_t *device, unsigned sh
 	if (rc != DC_STATUS_SUCCESS)
 		return rc;
 
+	HEXDUMP (device->base.context, DC_LOGLEVEL_DEBUG, "Handshake", handshake, sizeof(handshake) - 2);
+
 	// Store the clock calibration values.
 	device->systime = dc_datetime_now ();
 	device->devtime = array_uint32_le (handshake + 4);
diff --git a/src/seac_screen.c b/src/seac_screen.c
@@ -282,13 +282,17 @@ seac_screen_device_open (dc_device_t **out, dc_context_t *context, dc_iostream_t
 		goto error_free;
 	}
 
+	HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Hardware", device->info, SZ_HWINFO);
+
 	// Read the software info.
 	status = seac_screen_transfer (device, CMD_SWINFO, NULL, 0, device->info + SZ_HWINFO, SZ_SWINFO);
 	if (status != DC_STATUS_SUCCESS) {
 		ERROR (context, "Failed to read the software info.");
 		goto error_free;
 	}
 
+	HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Software", device->info + SZ_HWINFO, SZ_SWINFO);
+
 	*out = (dc_device_t *) device;
 
 	return DC_STATUS_SUCCESS;
diff --git a/src/shearwater_petrel.c b/src/shearwater_petrel.c
@@ -167,6 +167,8 @@ shearwater_petrel_device_foreach (dc_device_t *abstract, dc_dive_callback_t call
 		return rc;
 	}
 
+	HEXDUMP(abstract->context, DC_LOGLEVEL_DEBUG, "Serial", rsp_serial, sizeof(rsp_serial));
+
 	// Convert to a number.
 	unsigned char serial[4] = {0};
 	if (array_convert_hex2bin (rsp_serial, sizeof(rsp_serial), serial, sizeof (serial)) != 0 ) {
@@ -182,6 +184,8 @@ shearwater_petrel_device_foreach (dc_device_t *abstract, dc_dive_callback_t call
 		return rc;
 	}
 
+	HEXDUMP(abstract->context, DC_LOGLEVEL_DEBUG, "Firmware", rsp_firmware, sizeof(rsp_firmware));
+
 	// Convert to a number.
 	unsigned int firmware = str2num (rsp_firmware, sizeof(rsp_firmware), 1);
 
@@ -252,6 +256,8 @@ shearwater_petrel_device_foreach (dc_device_t *abstract, dc_dive_callback_t call
 			return rc;
 		}
 
+		HEXDUMP(abstract->context, DC_LOGLEVEL_DEBUG, "Manifest", dc_buffer_get_data (buffer), dc_buffer_get_size (buffer));
+
 		// Cache the buffer pointer and size.
 		unsigned char *data = dc_buffer_get_data (buffer);
 		unsigned int size = dc_buffer_get_size (buffer);
diff --git a/src/sporasub_sp2.c b/src/sporasub_sp2.c
@@ -282,6 +282,8 @@ sporasub_sp2_device_open (dc_device_t **out, dc_context_t *context, dc_iostream_
 		goto error_free;
 	}
 
+	HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Version", device->version, sizeof(device)->version);
+
 	*out = (dc_device_t *) device;
 
 	return DC_STATUS_SUCCESS;
diff --git a/src/suunto_d9.c b/src/suunto_d9.c
@@ -180,6 +180,8 @@ suunto_d9_device_open (dc_device_t **out, dc_context_t *context, dc_iostream_t *
 		goto error_free;
 	}
 
+	HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Version", device->base.version, sizeof (device->base.version));
+
 	// Override the base class values.
 	model = device->base.version[0];
 	if (model == D4i || model == D6i || model == D9tx ||
diff --git a/src/suunto_vyper2.c b/src/suunto_vyper2.c
@@ -141,6 +141,8 @@ suunto_vyper2_device_open (dc_device_t **out, dc_context_t *context, dc_iostream
 		goto error_timer_free;
 	}
 
+	HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Version", device->base.version, sizeof (device->base.version));
+
 	// Override the base class values.
 	unsigned int model = device->base.version[0];
 	if (model == HELO2)
diff --git a/src/tecdiving_divecomputereu.c b/src/tecdiving_divecomputereu.c
@@ -394,6 +394,8 @@ tecdiving_divecomputereu_device_open (dc_device_t **out, dc_context_t *context,
 		goto error_free;
 	}
 
+	HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Version", device->version, sizeof(device->version));
+
 	*out = (dc_device_t *) device;
 
 	return DC_STATUS_SUCCESS;
diff --git a/src/uwatec_smart.c b/src/uwatec_smart.c

Original file line number	Diff line number	Diff line change
`@@ -105,6 +105,8 @@ atomics_cobalt_device_open (dc_device_t *out, dc_context_t context, dc_iostrea`
`105`	`105`	`goto error_free;`
`106`	`106`	`}`
`107`	`107`
	`108`	`+ HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Version", device->version, sizeof (device->version));`
	`109`	`+`
`108`	`110`	`out = (dc_device_t) device;`
`109`	`111`
`110`	`112`	`return DC_STATUS_SUCCESS;`
Original file line number	Diff line number	Diff line change
`@@ -191,6 +191,8 @@ diverite_nitekq_device_open (dc_device_t *out, dc_context_t context, dc_iostre`
`191`	`191`	`goto error_free;`
`192`	`192`	`}`
`193`	`193`
	`194`	`+ HEXDUMP (context, DC_LOGLEVEL_DEBUG, "Version", device->version, sizeof (device->version));`
	`195`	`+`
`194`	`196`	`out = (dc_device_t) device;`
`195`	`197`
`196`	`198`	`return DC_STATUS_SUCCESS;`
Original file line number	Diff line number	Diff line change
`@@ -326,6 +326,8 @@ hw_frog_device_foreach (dc_device_t *abstract, dc_dive_callback_t callback, void`
`326`	`326`	`return rc;`
`327`	`327`	`}`
`328`	`328`
	`329`	`+ HEXDUMP (abstract->context, DC_LOGLEVEL_DEBUG, "Version", id, sizeof (id));`
	`330`	`+`
`329`	`331`	`// Emit a device info event.`
`330`	`332`	`dc_event_devinfo_t devinfo;`
`331`	`333`	`devinfo.model = 0;`