Skip to content

Commit af17878

Browse files
committed
Replace $VENDOR with $ARDMK_VENDOR as $VENDOR is a tcsh environment variable.
$ARCHITECTURE is probably safe as that's usually called $ARCH. Fixes issue #386. Need to decide if this is going to upset too many user's who have already started using $VENDOR - and who uses tcsh? ;-)
1 parent 3198aea commit af17878

File tree

4 files changed

+16
-15
lines changed

4 files changed

+16
-15
lines changed

Arduino.mk

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -319,11 +319,11 @@ endif
319319

320320
########################################################################
321321
# 1.5.x vendor - defaults to arduino
322-
ifndef VENDOR
323-
VENDOR = arduino
324-
$(call show_config_variable,VENDOR,[DEFAULT])
322+
ifndef ARDMK_VENDOR
323+
ARDMK_VENDOR = arduino
324+
$(call show_config_variable,ARDMK_VENDOR,[DEFAULT])
325325
else
326-
$(call show_config_variable,VENDOR,[USER])
326+
$(call show_config_variable,ARDMK_VENDOR,[USER])
327327
endif
328328

329329
########################################################################
@@ -474,7 +474,7 @@ $(call show_config_variable,ARDUINO_LIB_PATH,[COMPUTED],(from ARDUINO_DIR))
474474
ifndef ARDUINO_PLATFORM_LIB_PATH
475475
ifeq ($(shell expr $(ARDUINO_VERSION) '>' 150), 1)
476476
# only for 1.5
477-
ARDUINO_PLATFORM_LIB_PATH = $(ARDUINO_DIR)/hardware/$(VENDOR)/$(ARCHITECTURE)/libraries
477+
ARDUINO_PLATFORM_LIB_PATH = $(ARDUINO_DIR)/hardware/$(ARDMK_VENDOR)/$(ARCHITECTURE)/libraries
478478
$(call show_config_variable,ARDUINO_PLATFORM_LIB_PATH,[COMPUTED],(from ARDUINO_DIR))
479479
endif
480480
else
@@ -511,14 +511,14 @@ ifdef ALTERNATE_CORE_PATH
511511
else
512512

513513
ifndef ARDUINO_VAR_PATH
514-
ARDUINO_VAR_PATH = $(ARDUINO_DIR)/hardware/$(VENDOR)/$(ARCHITECTURE)/variants
514+
ARDUINO_VAR_PATH = $(ARDUINO_DIR)/hardware/$(ARDMK_VENDOR)/$(ARCHITECTURE)/variants
515515
$(call show_config_variable,ARDUINO_VAR_PATH,[COMPUTED],(from ARDUINO_DIR))
516516
else
517517
$(call show_config_variable,ARDUINO_VAR_PATH,[USER])
518518
endif
519519

520520
ifndef BOARDS_TXT
521-
BOARDS_TXT = $(ARDUINO_DIR)/hardware/$(VENDOR)/$(ARCHITECTURE)/boards.txt
521+
BOARDS_TXT = $(ARDUINO_DIR)/hardware/$(ARDMK_VENDOR)/$(ARCHITECTURE)/boards.txt
522522
$(call show_config_variable,BOARDS_TXT,[COMPUTED],(from ARDUINO_DIR))
523523
else
524524
$(call show_config_variable,BOARDS_TXT,[USER])
@@ -704,16 +704,16 @@ else
704704
$(call show_config_variable,OBJDIR,[USER])
705705
endif
706706

707-
# Now that we have ARDUINO_DIR, VENDOR, ARCHITECTURE and CORE,
707+
# Now that we have ARDUINO_DIR, ARDMK_VENDOR, ARCHITECTURE and CORE,
708708
# we can set ARDUINO_CORE_PATH.
709709
ifndef ARDUINO_CORE_PATH
710710
ifeq ($(strip $(CORE)),)
711-
ARDUINO_CORE_PATH = $(ARDUINO_DIR)/hardware/$(VENDOR)/$(ARCHITECTURE)/cores/arduino
711+
ARDUINO_CORE_PATH = $(ARDUINO_DIR)/hardware/$(ARDMK_VENDOR)/$(ARCHITECTURE)/cores/arduino
712712
$(call show_config_variable,ARDUINO_CORE_PATH,[DEFAULT])
713713
else
714714
ARDUINO_CORE_PATH = $(ALTERNATE_CORE_PATH)/cores/$(CORE)
715715
ifeq ($(wildcard $(ARDUINO_CORE_PATH)),)
716-
ARDUINO_CORE_PATH = $(ARDUINO_DIR)/hardware/$(VENDOR)/$(ARCHITECTURE)/cores/$(CORE)
716+
ARDUINO_CORE_PATH = $(ARDUINO_DIR)/hardware/$(ARDMK_VENDOR)/$(ARCHITECTURE)/cores/$(CORE)
717717
$(call show_config_variable,ARDUINO_CORE_PATH,[COMPUTED],(from ARDUINO_DIR, BOARD_TAG and boards.txt))
718718
else
719719
$(call show_config_variable,ARDUINO_CORE_PATH,[COMPUTED],(from ALTERNATE_CORE_PATH, BOARD_TAG and boards.txt))
@@ -1121,7 +1121,7 @@ endif
11211121

11221122
# either calculate parent dir from arduino dir, or user-defined path
11231123
ifndef BOOTLOADER_PARENT
1124-
BOOTLOADER_PARENT = $(ARDUINO_DIR)/hardware/$(VENDOR)/$(ARCHITECTURE)/bootloaders
1124+
BOOTLOADER_PARENT = $(ARDUINO_DIR)/hardware/$(ARDMK_VENDOR)/$(ARCHITECTURE)/bootloaders
11251125
$(call show_config_variable,BOOTLOADER_PARENT,[COMPUTED],(from ARDUINO_DIR))
11261126
else
11271127
$(call show_config_variable,BOOTLOADER_PARENT,[USER])

HISTORY.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ I tried to give credit whenever possible. If I have missed anyone, kindly add it
1919
- Fix: Preserve original extension for object files, support asm sources in core, fixes pulseInASM (Issue #255, #364) (https://github.com/sej7278)
2020
- Fix: Make sure TARGET is set correctly when CURDIR contains spaces (https://github.com/svendahlstrand)
2121
- Fix: Ensure AVRDUDE_CONF is set when AVR_TOOLS_DIR is, not just on Windows (Issue #381) (https://github.com/sej7278)
22+
- Fix: Rename VENDOR to ARDMK_VENDOR to workaround tcsh issue (Issue #386) (https://github.com/sej7278)
2223

2324
### 1.5 (2015-04-07)
2425
- New: Add support for new 1.5.x library layout (Issue #275) (https://github.com/lukasz-e)

Teensy.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ endif
3333
# include Common.mk now we know where it is
3434
include $(ARDMK_DIR)/Common.mk
3535

36-
VENDOR = teensy
36+
ARDMK_VENDOR = teensy
3737
ARDUINO_CORE_PATH = $(ARDUINO_DIR)/hardware/teensy/cores/teensy3
38-
BOARDS_TXT = $(ARDUINO_DIR)/hardware/$(VENDOR)/boards.txt
38+
BOARDS_TXT = $(ARDUINO_DIR)/hardware/$(ARDMK_VENDOR)/boards.txt
3939

4040
ifndef F_CPU
4141
F_CPU=96000000

arduino-mk-vars.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ ARCHITECTURE = sam
166166

167167
----
168168

169-
### VENDOR
169+
### ARDMK_VENDOR
170170

171171
**Description:**
172172

@@ -177,7 +177,7 @@ Defaults to `arduino`
177177
**Example:**
178178

179179
```Makefile
180-
VENDOR = sparkfun
180+
ARDMK_VENDOR = sparkfun
181181
```
182182

183183
**Requirement:** *Optional*

0 commit comments

Comments
 (0)