Remove requirement for library.properties file for user libraries. #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlfTetzlaff Thanks for the PR. @sej7278 I like the idea of using different directories for the user code and libraries. But I am not sure if it will break any of our existing assumptions. What are your thoughts on this? |
|
i don't think this will break things and the missing library.properties thing has bitten me recently for my own libs 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the requirement for user libraries to provide a library.properties file, which caused quite a headache for me, because I wondered why my own written libraries were never found.
One could further alter the provided solution in order to allow for separate /include and /src subfolders, which is also a common file structure.