Merge pull request #18 from sudiptpa/fix/payment-verify-bug

Added a Fix for Transaction Verify Bug

Author: sudiptpa

README.md

@@ -29,7 +29,7 @@ composer require league/omnipay sudiptpa/omnipay-esewa
 
     $gateway = Omnipay::create('Esewa_Secure');
 
-    $gateway->setMerchantCode('test_merchant');
+    $gateway->setMerchantCode('epay_payment');
     $gateway->setTestMode(true);
 
     try {
@@ -57,7 +57,7 @@ composer require league/omnipay sudiptpa/omnipay-esewa
 ```php
     $gateway = Omnipay::create('Esewa_Secure');
 
-    $gateway->setMerchantCode('test_merchant');
+    $gateway->setMerchantCode('epay_payment');
     $gateway->setTestMode(true);
 
     $response = $gateway->verifyPayment([

demo.php

@@ -6,7 +6,7 @@
 
 $gateway = Omnipay::create('Esewa_Secure');
 
-$gateway->setMerchantCode('test_merchant');
+$gateway->setMerchantCode('epay_payment');
 $gateway->setTestMode(true);
 
 $response = $gateway->purchase([

src/Message/VerifyPaymentRequest.php

@@ -14,6 +14,11 @@ class VerifyPaymentRequest extends AbstractRequest
      */
     protected $verifyEndPoint = 'epay/transrec';
 
+    /**
+     * @var string
+     */
+    protected $userAgent = 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116 Safari/537.36';
+
     /**
      * @return string
      */
@@ -27,20 +32,40 @@ public function getData()
         ];
     }
 
+    /**
+     * @return string
+     */
+    public function getUserAgent()
+    {
+        $userAgent = $this->userAgent;
+
+        if (isset($_SERVER['HTTP_USER_AGENT'])) {
+            $userAgent = $_SERVER['HTTP_USER_AGENT'];
+        }
+
+        return $userAgent;
+    }
+
     /**
      * @param $data
      *
-     * @return \Omnipay\Esewa\Message\OrderResponse
+     * @return \Omnipay\Esewa\Message\VerifyPaymentResponse
      */
     public function sendData($data)
     {
-        $endPoint = $this->getEndpoint().'?'.http_build_query($data);
+        $endPoint = $this->getEndpoint();
+
+        $headers = [
+            'User-Agent'   => $this->getUserAgent(),
+            'Accept'       => 'application/xml',
+            'Content-Type' => 'application/x-www-form-urlencoded; charset=utf-8',
+        ];
 
-        $httpResponse = $this->httpClient->request('GET', $endPoint);
+        $httpResponse = $this->httpClient->request('POST', $endPoint, $headers, http_build_query($data));
 
-        $data = new SimpleXMLElement($httpResponse->getBody()->getContents());
+        $content = new SimpleXMLElement($httpResponse->getBody()->getContents());
 
-        return $this->response = new VerifyPaymentResponse($this, $data);
+        return $this->response = new VerifyPaymentResponse($this, $content);
     }
 
     /**

src/Message/VerifyPaymentResponse.php

@@ -25,14 +25,16 @@ public function __construct(RequestInterface $request, $data)
      */
     public function getResponseText()
     {
-        return (string) $this->data->response_code;
+        return (string) trim($this->data->response_code);
     }
 
     /**
      * @return bool
      */
     public function isSuccessful()
     {
-        return in_array($this->getResponseText(), ['Success']);
+        $string = strtolower($this->getResponseText());
+
+        return in_array($string, ['success']);
     }
 }

tests/Message/PurchaseRequestTest.php

@@ -14,7 +14,7 @@ public function setUp()
         $this->request = new PurchaseRequest($this->getHttpClient(), $this->getHttpRequest());
 
         $this->request->initialize([
-            'merchantCode'   => 'test_merchant',
+            'merchantCode'   => 'epay_payment',
             'amount'         => 100,
             'deliveryCharge' => 0,
             'serviceCharge'  => 0,

tests/Message/VerifyPaymentRequestTest.php

@@ -14,7 +14,7 @@ public function setUp()
         $this->request = new VerifyPaymentRequest($this->getHttpClient(), $this->getHttpRequest());
 
         $this->request->initialize([
-            'merchantCode'    => 'test_merchant',
+            'merchantCode'    => 'epay_payment',
             'testMode'        => true,
             'amount'          => 100,
             'referenceNumber' => 'GDFG89',

tests/SecureGatewayTest.php

@@ -14,7 +14,7 @@ public function setUp()
         parent::setUp();
 
         $this->gateway = new SecureGateway($this->getHttpClient(), $this->getHttpRequest());
-        $this->gateway->setMerchantCode('test_merchant');
+        $this->gateway->setMerchantCode('epay_payment');
     }
 
     public function testPurchase()