Disable use of C23 attributes when using PVS Studio

PVS Studio does not support C23 attributes.

Author: millert

config.h.in

@@ -743,6 +743,9 @@
 /* Define to 1 if you have the <pty.h> header file. */
 #undef HAVE_PTY_H
 
+/* Define to 1 if you are using PVS Studio to scan sudo. */
+#undef HAVE_PVS_STUDIO
+
 /* Define to 1 if you have the 'pwrite' function. */
 #undef HAVE_PWRITE
 
@@ -1582,7 +1585,7 @@ typedef unsigned int		socklen_t;
 #endif
 
 /* For functions that call exit() directly. */
-#ifdef __has_c_attribute
+#if defined(__has_c_attribute) && !defined(HAVE_PVS_STUDIO)
 # if __has_c_attribute(__noreturn__)
 #  define sudo_noreturn		[[__noreturn__]]
 # endif
@@ -1621,7 +1624,7 @@ typedef unsigned int		socklen_t;
 #endif
 
 /* C23 defines a fallthrough attribute, gcc 7.0 and clang 10 have their own. */
-#ifdef __has_c_attribute
+#if defined(__has_c_attribute) && !defined(HAVE_PVS_STUDIO)
 # if __has_c_attribute(__fallthrough__)
 # define FALLTHROUGH		[[__fallthrough__]]
 # endif

configure

@@ -8955,6 +8955,9 @@ case $host_os in *\ *) host_os=`echo "$host_os" | sed 's/ /-/g'`;; esac
 
 
     if test X"$enable_pvs_studio" = X"yes"; then
+	printf "%s\n" "#define HAVE_PVS_STUDIO 1" >>confdefs.h
+
+
 	# Determine preprocessor type
 	case "$CC" in
 	*clang*) preprocessor=clang;;
@@ -40104,5 +40107,6 @@ fi
 
 
 
+
 
 

configure.ac

@@ -4794,6 +4794,7 @@ AH_TEMPLATE(SUDOERS_LOG_CLIENT, [Define to 1 to compile support for sudo_logsrvd
 AH_TEMPLATE(HAVE_FALLTHROUGH_ATTRIBUTE, [Define to 1 if the compiler supports the fallthrough attribute.])
 AH_TEMPLATE(HAVE_VA_COPY, [Define to 1 if you have the 'va_copy' function.])
 AH_TEMPLATE(HAVE___VA_COPY, [Define to 1 if you have the '__va_copy' function.])
+AH_TEMPLATE(HAVE_PVS_STUDIO, [Define to 1 if you are using PVS Studio to scan sudo.])
 
 dnl
 dnl Bits to copy verbatim into config.h.in
@@ -4827,7 +4828,7 @@ typedef unsigned int		socklen_t;
 #endif
 
 /* For functions that call exit() directly. */
-#ifdef __has_c_attribute
+#if defined(__has_c_attribute) && !defined(HAVE_PVS_STUDIO)
 # if __has_c_attribute(__noreturn__)
 #  define sudo_noreturn		[[__noreturn__]]
 # endif
@@ -4866,7 +4867,7 @@ typedef unsigned int		socklen_t;
 #endif
 
 /* C23 defines a fallthrough attribute, gcc 7.0 and clang 10 have their own. */
-#ifdef __has_c_attribute
+#if defined(__has_c_attribute) && !defined(HAVE_PVS_STUDIO)
 # if __has_c_attribute(__fallthrough__)
 # define FALLTHROUGH		[[__fallthrough__]]
 # endif

m4/sudo.m4

@@ -595,6 +595,8 @@ dnl Create PVS-Studio.cfg for supported platforms or throw an error.
 dnl
 AC_DEFUN([SUDO_PVS_STUDIO_CFG], [
     if test X"$enable_pvs_studio" = X"yes"; then
+	AC_DEFINE(HAVE_PVS_STUDIO)
+
 	# Determine preprocessor type
 	case "$CC" in
 	*clang*) preprocessor=clang;;