validate_hostname: Don't initialize ret, it is set immediately

millert · millert · commit 18123e31b384 · 2025-10-30T08:24:54.000-06:00
Initializing ret to MatchFound makes it appear that the
default return value is MatchFound, which is not correct.
diff --git a/lib/iolog/hostcheck.c b/lib/iolog/hostcheck.c
@@ -256,7 +256,7 @@ matches_subject_alternative_name(const char *hostname, const char *ipaddr,
 HostnameValidationResult
 validate_hostname(X509 *cert, const char *hostname, const char *ipaddr)
 {
-    HostnameValidationResult ret = MatchFound;
+    HostnameValidationResult ret;
     debug_decl(validate_hostname, SUDO_DEBUG_UTIL);
 
     /* Check SAN first if exists */

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ matches_subject_alternative_name(const char hostname, const char ipaddr,`
`256`	`256`	`HostnameValidationResult`
`257`	`257`	`validate_hostname(X509 cert, const char hostname, const char *ipaddr)`
`258`	`258`	`{`
`259`		`- HostnameValidationResult ret = MatchFound;`
	`259`	`+ HostnameValidationResult ret;`
`260`	`260`	`debug_decl(validate_hostname, SUDO_DEBUG_UTIL);`
`261`	`261`
`262`	`262`	`/* Check SAN first if exists */`