prepare_listener: initialize sock to -1

millert · millert · commit 25d1f08fffa7 · 2025-10-30T13:26:06.000-06:00
Fixes a bug on the error path at the bad: label where it is assumed that sock is either a valid fd or -1. Found by the ZeroPath AI Security Engineer <https://zeropath.com>
diff --git a/src/exec_intercept.c b/src/exec_intercept.c
@@ -222,7 +222,7 @@ prepare_listener(struct intercept_closure *closure)
 {
     struct sockaddr_in sin4;
     socklen_t sin4_len = sizeof(sin4);
-    int sock;
+    int sock = -1;
     debug_decl(prepare_listener, SUDO_DEBUG_EXEC);
 
     /* Generate a random token. */

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,7 @@ prepare_listener(struct intercept_closure *closure)`
`222`	`222`	`{`
`223`	`223`	`struct sockaddr_in sin4;`
`224`	`224`	`socklen_t sin4_len = sizeof(sin4);`
`225`		`- int sock;`
	`225`	`+ int sock = -1;`
`226`	`226`	`debug_decl(prepare_listener, SUDO_DEBUG_EXEC);`
`227`	`227`
`228`	`228`	`/* Generate a random token. */`