Set closure->disabled on I/O error even if not ignoring errors.

Now that we free the client closure contents immediately, we need
to set the disabled flag to prevent log_server_close() from trying
to use the closure.

Author: millert

plugins/sudoers/audit.c

@@ -301,6 +301,7 @@ log_server_exit(int status_type, int status)
 {
     debug_decl(log_server_exit, SUDOERS_DEBUG_PLUGIN);
 
+    /* Only send exit status to log server if I/O logging plugin did not. */
     if (client_closure != NULL) {
 	int exit_status = 0, error = 0;
 

plugins/sudoers/log_client.c

@@ -1883,10 +1883,9 @@ server_msg_cb(int fd, int what, void *v)
     buf->off = 0;
     debug_return;
 bad:
-    if (closure->log_details->ignore_log_errors) {
-	/* Disable log server connection, the command continues. */
-	closure->disabled = true;
-    } else {
+    /* Disable further log server operations. */
+    closure->disabled = true;
+    if (!closure->log_details->ignore_log_errors) {
 	/* Break out of sudo event loop and kill the command. */
 	closure->read_ev->loopbreak(closure->read_ev);
     }
@@ -2004,12 +2003,11 @@ client_msg_cb(int fd, int what, void *v)
     debug_return;
 
 bad:
-    if (closure->log_details->ignore_log_errors) {
-	/* Disable log server connection, the command continues. */
-	closure->disabled = true;
-    } else {
+    /* Disable further log server operations. */
+    closure->disabled = true;
+    if (!closure->log_details->ignore_log_errors) {
 	/* Break out of sudo event loop and kill the command. */
-	closure->write_ev->loopbreak(closure->write_ev);
+	closure->read_ev->loopbreak(closure->read_ev);
     }
     client_closure_free_contents(closure);
     debug_return;