iolog_store_uuid: Fix file descriptor leak on success

millert · millert · commit 658bbc4af983 · 2025-11-08T15:46:01.000-07:00
Found by the ZeroPath AI Security Engineer <https://zeropath.com>
diff --git a/logsrvd/iolog_writer.c b/logsrvd/iolog_writer.c
@@ -726,6 +726,7 @@ iolog_store_uuid(int dfd, struct connection_closure *closure)
 	    "uuid");
         goto bad;
     }
+    close(fd);
 
     debug_return_bool(true);
 bad:

Original file line number	Diff line number	Diff line change
`@@ -726,6 +726,7 @@ iolog_store_uuid(int dfd, struct connection_closure *closure)`
`726`	`726`	`"uuid");`
`727`	`727`	`goto bad;`
`728`	`728`	`}`
	`729`	`+ close(fd);`
`729`	`730`
`730`	`731`	`debug_return_bool(true);`
`731`	`732`	`bad:`