log_server_connect: Close socket on error

millert · millert · commit 7f6de89dc63c · 2025-09-14T16:22:04.000-06:00
Fixes a potential fd leak on the error path.

Thanks to Joshua Rogers for finding this.
diff --git a/plugins/sudoers/log_client.c b/plugins/sudoers/log_client.c
@@ -638,8 +638,11 @@ log_server_connect(struct client_closure *closure)
     }
     free(copy);
 
-    if (!ret && cause != NULL)
-        sudo_warn("%s", cause);
+    if (!ret) {
+	if (cause != NULL)
+	    sudo_warn("%s", cause);
+	close(sock);
+    }
 
     debug_return_bool(ret);
 }

Original file line number	Diff line number	Diff line change
`@@ -638,8 +638,11 @@ log_server_connect(struct client_closure *closure)`
`638`	`638`	`}`
`639`	`639`	`free(copy);`
`640`	`640`
`641`		`- if (!ret && cause != NULL)`
`642`		`- sudo_warn("%s", cause);`
	`641`	`+ if (!ret) {`
	`642`	`+ if (cause != NULL)`
	`643`	`+ sudo_warn("%s", cause);`
	`644`	`+ close(sock);`
	`645`	`+ }`
`643`	`646`
`644`	`647`	`debug_return_bool(ret);`
`645`	`648`	`}`