Skip to content

Commit 865f11c

Browse files
committed
Call client_closure_free_contents() before setting closure->disabled.
This makes no real difference but it makes clear that the disabled flag cannot be cleared by client_closure_free_contents().
1 parent ad4bf88 commit 865f11c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

plugins/sudoers/log_client.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1884,12 +1884,12 @@ server_msg_cb(int fd, int what, void *v)
18841884
debug_return;
18851885
bad:
18861886
/* Disable further log server operations. */
1887+
client_closure_free_contents(closure);
18871888
closure->disabled = true;
18881889
if (!closure->log_details->ignore_log_errors) {
18891890
/* Break out of sudo event loop and kill the command. */
18901891
closure->read_ev->loopbreak(closure->read_ev);
18911892
}
1892-
client_closure_free_contents(closure);
18931893
debug_return;
18941894
}
18951895

@@ -2004,12 +2004,12 @@ client_msg_cb(int fd, int what, void *v)
20042004

20052005
bad:
20062006
/* Disable further log server operations. */
2007+
client_closure_free_contents(closure);
20072008
closure->disabled = true;
20082009
if (!closure->log_details->ignore_log_errors) {
20092010
/* Break out of sudo event loop and kill the command. */
20102011
closure->read_ev->loopbreak(closure->read_ev);
20112012
}
2012-
client_closure_free_contents(closure);
20132013
debug_return;
20142014
}
20152015

0 commit comments

Comments
 (0)