sudoers_init: ret still needs to be static

millert · millert · commit bc020f401b30 · 2025-11-15T11:31:50.000-07:00
Otherwise, sudoers_init() will return -1 even if it has successfully
initialized earlier.
diff --git a/plugins/sudoers/sudoers.c b/plugins/sudoers/sudoers.c
@@ -186,7 +186,7 @@ sudoers_init(void *info, sudoers_logger_t logger, char * const envp[])
 {
     struct sudo_nss *nss, *nss_next;
     int oldlocale, sources = 0;
-    int ret = -1;
+    static int ret = -1;
     debug_decl(sudoers_init, SUDOERS_DEBUG_PLUGIN);
 
     /* Only attempt to initialize once. */

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ sudoers_init(void info, sudoers_logger_t logger, char const envp[])`
`186`	`186`	`{`
`187`	`187`	`struct sudo_nss nss, nss_next;`
`188`	`188`	`int oldlocale, sources = 0;`
`189`		`- int ret = -1;`
	`189`	`+ static int ret = -1;`
`190`	`190`	`debug_decl(sudoers_init, SUDOERS_DEBUG_PLUGIN);`
`191`	`191`
`192`	`192`	`/* Only attempt to initialize once. */`