copy_arg: use src_end when checking for quoted chars

millert · millert · commit e1829a19d930 · 2025-10-22T09:32:11.000-06:00
Same fix as af58de4. Reported by Reaxx.
diff --git a/plugins/sudoers/editor.c b/plugins/sudoers/editor.c
@@ -98,7 +98,7 @@ copy_arg(const char *src, size_t len)
     if ((copy = malloc(len + 1)) != NULL) {
 	sudoers_gc_add(GC_PTR, copy);
 	for (dst = copy; src < src_end; ) {
-	    if (src[0] == '\\' && src[1] != '\0')
+	    if (*src == '\\' && src + 1 < src_end)
 		src++;
 	    *dst++ = *src++;
 	}

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ copy_arg(const char *src, size_t len)`
`98`	`98`	`if ((copy = malloc(len + 1)) != NULL) {`
`99`	`99`	`sudoers_gc_add(GC_PTR, copy);`
`100`	`100`	`for (dst = copy; src < src_end; ) {`
`101`		`- if (src[0] == '\\' && src[1] != '\0')`
	`101`	`+ if (*src == '\\' && src + 1 < src_end)`
`102`	`102`	`src++;`
`103`	`103`	`dst++ = src++;`
`104`	`104`	`}`