Commit 335f15c
committed
test(replay): fix full session replay
The issue is a bit subtle: the event notification about the session
changing from nil to an id gets wrapped in vim.schedule but that means
it gets delivered after we've loaded the fulls session, which causes us
to clear the whole session right after we just loaded it, leaving the
output blank.
It's possible that we might want to not wrap state notifications in
vim.schedule and expect listeners to handle cases where they can't be in
a fast context. The primary benefit of that would be guaranteed ordering
of events.
For example, in this case, the event that the session was set would've
been processed before we loaded the session so the issue wouldn't exist.1 parent 338efa8 commit 335f15c
2 files changed
+8
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | 24 | | |
26 | | - | |
| 25 | + | |
27 | 26 | | |
28 | 27 | | |
29 | | - | |
| 28 | + | |
30 | 29 | | |
31 | 30 | | |
32 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
199 | | - | |
| 199 | + | |
| 200 | + | |
200 | 201 | | |
201 | | - | |
202 | | - | |
203 | | - | |
| 202 | + | |
| 203 | + | |
204 | 204 | | |
205 | | - | |
| 205 | + | |
| 206 | + | |
206 | 207 | | |
207 | 208 | | |
208 | 209 | | |
| |||
0 commit comments