test(hooks): Test on_done_thinking and on_permission_requested hooks

Author: guillaumeboehm

tests/unit/hooks_spec.lua

@@ -10,6 +10,8 @@ describe('hooks', function()
     config.hooks = {
       on_file_edited = nil,
       on_session_loaded = nil,
+      on_done_thinking = nil,
+      on_permission_requested = nil,
     }
   end)
 
@@ -20,6 +22,8 @@ describe('hooks', function()
     config.hooks = {
       on_file_edited = nil,
       on_session_loaded = nil,
+      on_done_thinking = nil,
+      on_permission_requested = nil,
     }
   end)
 
@@ -107,4 +111,74 @@ describe('hooks', function()
       end)
     end)
   end)
+
+  describe('on_done_thinking', function()
+    it('should call hook when thinking is done', function()
+      local called = false
+
+      config.hooks.on_done_thinking = function()
+        called = true
+      end
+
+      -- Simulate job count change from 1 to 0 (done thinking)
+      state.user_message_count = 1
+      state.user_message_count = 0
+
+      assert.is_true(called)
+    end)
+
+    it('should not error when hook is nil', function()
+      config.hooks.on_done_thinking = nil
+      state.user_message_count = 1
+      assert.has_no.errors(function()
+        state.user_message_count = 0
+      end)
+    end)
+
+    it('should not crash when hook throws error', function()
+      config.hooks.on_done_thinking = function()
+        error('test error')
+      end
+
+      state.user_message_count = 1
+      assert.has_no.errors(function()
+        state.user_message_count = 0
+      end)
+    end)
+  end)
+
+  describe('on_permission_requested', function()
+    it('should call hook when permission is requested', function()
+      local called = false
+
+      config.hooks.on_permission_requested = function()
+        called = true
+      end
+
+      -- Simulate permission change from nil to a value
+      state.current_permission = nil
+      state.current_permission = { tool = 'test_tool', action = 'read' }
+
+      assert.is_true(called)
+    end)
+
+    it('should not error when hook is nil', function()
+      config.hooks.on_permission_requested = nil
+      state.current_permission = nil
+      assert.has_no.errors(function()
+        state.current_permission = { tool = 'test_tool', action = 'read' }
+      end)
+    end)
+
+    it('should not crash when hook throws error', function()
+      config.hooks.on_permission_requested = function()
+        error('test error')
+      end
+
+      state.current_permission = nil
+      assert.has_no.errors(function()
+        state.current_permission = { tool = 'test_tool', action = 'read' }
+      end)
+    end)
+  end)
 end)