chore: emmylua_ls type cleanup

Author: cameronr

lua/opencode/api_client.lua

@@ -37,6 +37,10 @@ function OpencodeApiClient:_ensure_base_url()
     end
   end
 
+  if not state.opencode_server.url then
+    return false
+  end
+
   self.base_url = state.opencode_server.url:gsub('/$', '')
   return true
 end
@@ -49,7 +53,7 @@ end
 --- @return Promise<any> promise
 function OpencodeApiClient:_call(endpoint, method, body, query)
   if not self:_ensure_base_url() then
-    return nil
+    return require('opencode.promise').new():reject('No server base url')
   end
   local url = self.base_url .. endpoint
 
@@ -393,7 +397,7 @@ function OpencodeApiClient:subscribe_to_events(directory, on_event)
     chunk = chunk:gsub('^data:%s*', '')
     local ok, event = pcall(vim.json.decode, vim.trim(chunk))
     if ok and event then
-      on_event(event)
+      on_event(event --[[@as table]])
     end
   end)
 end

lua/opencode/health.lua

@@ -111,6 +111,8 @@ local function check_configuration()
     return
   end
 
+  ---@cast config OpencodeConfig
+
   local valid_positions = { 'left', 'right', 'top', 'bottom' }
   if not vim.tbl_contains(valid_positions, config.ui.position) then
     health.warn(

lua/opencode/keymap.lua

@@ -34,7 +34,7 @@ end
 
 -- Setup window-specific keymaps (shared helper for input/output windows)
 ---@param keymap_config table Window keymap configuration
----@param buf_id number Buffer ID to set keymaps for
+---@param buf_id integer Buffer ID to set keymaps for
 function M.setup_window_keymaps(keymap_config, buf_id)
   if not vim.api.nvim_buf_is_valid(buf_id) then
     return

lua/opencode/state.lua

@@ -11,9 +11,9 @@
 ---@field input_content table
 ---@field is_opencode_focused boolean
 ---@field last_focused_opencode_window string|nil
----@field last_input_window_position number|nil
----@field last_output_window_position number|nil
----@field last_code_win_before_opencode number|nil
+---@field last_input_window_position integer[]|nil
+---@field last_output_window_position integer[]|nil
+---@field last_code_win_before_opencode integer|nil
 ---@field current_code_buf number|nil
 ---@field display_route any|nil
 ---@field current_mode string

lua/opencode/ui/autocmds.lua

@@ -59,7 +59,7 @@ function M.setup_resize_handler(windows)
   vim.api.nvim_create_autocmd('WinResized', {
     group = resize_group,
     callback = function(args)
-      local win = tonumber(args.match)
+      local win = tonumber(args.match) --[[@as integer]]
       if not win or not vim.api.nvim_win_is_valid(win) or not output_window.mounted() then
         return
       end

lua/opencode/ui/footer.lua

@@ -10,10 +10,10 @@ local loading_animation = require('opencode.ui.loading_animation')
 local M = {}
 
 function M.render()
-  local windows = state.windows
-  if not output_window.mounted(windows) or not M.mounted(windows) then
+  if not output_window.mounted() or not M.mounted() then
     return
   end
+  ---@cast state.windows { output_win: integer }
 
   local segments = {}
 
@@ -46,23 +46,22 @@ function M.render()
     append_to_footer(restore_point_text)
   end
 
-  ---@diagnostic disable-next-line: need-check-nil
-  local win_width = vim.api.nvim_win_get_width(windows.output_win)
+  local win_width = vim.api.nvim_win_get_width(state.windows.output_win)
   local footer_text = table.concat(segments, ' | ') .. ' '
   footer_text = string.rep(' ', win_width - #footer_text) .. footer_text
 
   M.set_content({ footer_text })
 end
 
----@param windows OpencodeWindowState
-function M._build_footer_win_config(windows)
+---@param output_win integer
+function M._build_footer_win_config(output_win)
   return {
     relative = 'win',
-    win = windows.output_win,
+    win = output_win,
     anchor = 'SW',
-    width = vim.api.nvim_win_get_width(windows.output_win),
+    width = vim.api.nvim_win_get_width(output_win),
     height = 1,
-    row = vim.api.nvim_win_get_height(windows.output_win) - 1,
+    row = vim.api.nvim_win_get_height(output_win) - 1,
     col = 0,
     focusable = false,
     style = 'minimal',
@@ -82,7 +81,11 @@ local function on_job_count_changed(_, new, old)
 end
 
 function M.setup(windows)
-  windows.footer_win = vim.api.nvim_open_win(windows.footer_buf, false, M._build_footer_win_config(windows))
+  if not windows.output_win then
+    return false
+  end
+
+  windows.footer_win = vim.api.nvim_open_win(windows.footer_buf, false, M._build_footer_win_config(windows.output_win))
   vim.api.nvim_set_option_value('winhl', 'Normal:OpenCodeHint', { win = windows.footer_win })
 
   -- for stats changes
@@ -95,7 +98,9 @@ function M.setup(windows)
 end
 
 function M.close()
-  if state.windows then
+  if M.mounted() then
+    ---@cast state.windows { footer_win: integer, footer_buf: integer }
+
     pcall(vim.api.nvim_win_close, state.windows.footer_win, true)
     pcall(vim.api.nvim_buf_delete, state.windows.footer_buf, { force = true })
   end
@@ -112,15 +117,17 @@ function M.mounted(windows)
   return windows
     and windows.footer_win
     and vim.api.nvim_win_is_valid(windows.footer_win)
+    and windows.output_win
     and vim.api.nvim_win_is_valid(windows.output_win)
+    and windows.footer_buf
 end
 
 function M.update_window(windows)
   if not M.mounted(windows) then
     return
   end
 
-  vim.api.nvim_win_set_config(windows.footer_win, M._build_footer_win_config(windows))
+  vim.api.nvim_win_set_config(windows.footer_win, M._build_footer_win_config(windows.output_win))
   M.render()
 end
 
@@ -132,29 +139,26 @@ function M.create_buf()
 end
 
 function M.clear()
-  local windows = state.windows
-  if not M.mounted() or not windows then
+  if not M.mounted() then
     return
   end
+  ---@cast state.windows { footer_buf: integer }
 
   local foot_ns_id = vim.api.nvim_create_namespace('opencode_footer')
-  vim.api.nvim_buf_clear_namespace(windows.footer_buf, foot_ns_id, 0, -1)
+  vim.api.nvim_buf_clear_namespace(state.windows.footer_buf, foot_ns_id, 0, -1)
 
   M.set_content({})
-  --
-  -- state.tokens_count = 0
-  -- state.cost = 0
 end
 
 function M.set_content(lines)
-  local windows = state.windows
-  if not M.mounted() or not windows then
+  if not M.mounted() then
     return
   end
+  ---@cast state.windows { footer_buf: integer }
 
-  vim.api.nvim_set_option_value('modifiable', true, { buf = windows.footer_buf })
-  vim.api.nvim_buf_set_lines(windows.footer_buf, 0, -1, false, lines)
-  vim.api.nvim_set_option_value('modifiable', false, { buf = windows.footer_buf })
+  vim.api.nvim_set_option_value('modifiable', true, { buf = state.windows.footer_buf })
+  vim.api.nvim_buf_set_lines(state.windows.footer_buf, 0, -1, false, lines)
+  vim.api.nvim_set_option_value('modifiable', false, { buf = state.windows.footer_buf })
 end
 
 return M

lua/opencode/ui/mention.lua

@@ -1,5 +1,3 @@
-local config = require('opencode.config')
-
 local M = {}
 
 local mentions_namespace = vim.api.nvim_create_namespace('OpencodeMentions')
@@ -25,6 +23,7 @@ function M.highlight_all_mentions(buf, callback)
       if not mention_start then
         break
       end
+      ---@cast mention_start integer
 
       if callback then
         callback(line:sub(mention_start + 1, mention_end), row, mention_start, mention_end)
@@ -82,7 +81,7 @@ function M.highlight_mentions_in_output(output, text, mentions, start_line)
             end_col = col_end,
             hl_group = 'OpencodeMention',
             priority = 1000,
-          })
+          } --[[@as OutputExtmark]])
           break
         end
 
@@ -91,9 +90,14 @@ function M.highlight_mentions_in_output(output, text, mentions, start_line)
     end
   end
 end
+
 local function insert_mention(windows, row, col, name)
   local current_line = vim.api.nvim_buf_get_lines(windows.input_buf, row - 1, row, false)[1]
 
+  if not current_line then
+    return
+  end
+
   local insert_name = '@' .. name .. ' '
 
   local new_line = current_line:sub(1, col) .. insert_name .. current_line:sub(col + 2)
@@ -111,7 +115,7 @@ function M.mention(get_name)
 
   get_name(function(name)
     vim.schedule(function()
-      if not windows or not name then
+      if not windows or not windows.input_win or not name then
         return
       end
       local cursor_pos = vim.api.nvim_win_get_cursor(windows.input_win)

lua/opencode/ui/output_window.lua

@@ -24,16 +24,7 @@ end
 
 function M.mounted(windows)
   windows = windows or state.windows
-  if
-    not state.windows
-    or not state.windows.output_buf
-    or not state.windows.output_win
-    or not vim.api.nvim_win_is_valid(windows.output_win)
-  then
-    return false
-  end
-
-  return true
+  return windows and windows.output_buf and windows.output_win and vim.api.nvim_win_is_valid(windows.output_win)
 end
 
 function M.setup(windows)
@@ -66,6 +57,7 @@ function M.get_buf_line_count()
   if not M.mounted() then
     return 0
   end
+  ---@cast state.windows { output_buf: integer }
 
   return vim.api.nvim_buf_line_count(state.windows.output_buf)
 end
@@ -78,28 +70,25 @@ function M.set_lines(lines, start_line, end_line)
   if not M.mounted() then
     return
   end
+  ---@cast state.windows { output_buf: integer }
 
   start_line = start_line or 0
   end_line = end_line or -1
 
-  local windows = state.windows
-  if not windows or not windows.output_buf then
-    return
-  end
-
-  vim.api.nvim_set_option_value('modifiable', true, { buf = windows.output_buf })
-  vim.api.nvim_buf_set_lines(windows.output_buf, start_line, end_line, false, lines)
-  vim.api.nvim_set_option_value('modifiable', false, { buf = windows.output_buf })
+  vim.api.nvim_set_option_value('modifiable', true, { buf = state.windows.output_buf })
+  vim.api.nvim_buf_set_lines(state.windows.output_buf, start_line, end_line, false, lines)
+  vim.api.nvim_set_option_value('modifiable', false, { buf = state.windows.output_buf })
 end
 
 ---Clear output buf extmarks
 ---@param start_line? integer Line to start clearing, defaults 0
 ---@param end_line? integer Line to clear until, defaults to -1
 ---@param clear_all? boolean If true, clears all extmarks in the buffer
 function M.clear_extmarks(start_line, end_line, clear_all)
-  if not M.mounted() or not state.windows.output_buf then
+  if not M.mounted() then
     return
   end
+  ---@cast state.windows { output_buf: integer }
 
   start_line = start_line or 0
   end_line = end_line or -1
@@ -108,12 +97,13 @@ function M.clear_extmarks(start_line, end_line, clear_all)
 end
 
 ---Apply extmarks to the output buffer
----@param extmarks table<number, OutputExtmark> Extmarks indexed by line
+---@param extmarks table<number, OutputExtmark[]> Extmarks indexed by line
 ---@param line_offset? integer Line offset to apply to extmarks, defaults to 0
 function M.set_extmarks(extmarks, line_offset)
   if not M.mounted() or not extmarks or type(extmarks) ~= 'table' then
     return
   end
+  ---@cast state.windows { output_buf: integer }
 
   line_offset = line_offset or 0
 
@@ -122,20 +112,26 @@ function M.set_extmarks(extmarks, line_offset)
   for line_idx, marks in pairs(extmarks) do
     for _, mark in ipairs(marks) do
       local actual_mark = type(mark) == 'function' and mark() or mark
-      local target_line = line_offset + line_idx
+      local target_line = line_offset + line_idx --[[@as integer]]
       if actual_mark.end_row then
         actual_mark.end_row = actual_mark.end_row + line_offset
       end
       local start_col = actual_mark.start_col
       if actual_mark.start_col then
         actual_mark.start_col = nil
       end
+      ---@cast actual_mark vim.api.keyset.set_extmark
       pcall(vim.api.nvim_buf_set_extmark, output_buf, M.namespace, target_line, start_col or 0, actual_mark)
     end
   end
 end
 
 function M.focus_output(should_stop_insert)
+  if not M.mounted() then
+    return
+  end
+  ---@cast state.windows { output_win: integer }
+
   if should_stop_insert then
     vim.cmd('stopinsert')
   end
@@ -146,6 +142,8 @@ function M.close()
   if M.mounted() then
     return
   end
+  ---@cast state.windows { output_win: integer, output_buf: integer }
+
   pcall(vim.api.nvim_win_close, state.windows.output_win, true)
   pcall(vim.api.nvim_buf_delete, state.windows.output_buf, { force = true })
 end

lua/opencode/ui/renderer.lua

@@ -22,7 +22,7 @@ local trigger_on_data_rendered = require('opencode.util').debounce(function()
     return
   end
 
-  if not state.windows then
+  if not state.windows or not state.windows.output_buf or not state.windows.output_win then
     return
   end
 

lua/opencode/ui/ui.lua

@@ -23,6 +23,7 @@ function M.close_windows(windows)
   pcall(vim.api.nvim_del_augroup_by_name, 'OpencodeResize')
   pcall(vim.api.nvim_del_augroup_by_name, 'OpencodeWindows')
 
+  ---@cast windows { input_win: integer, output_win: integer, input_buf: integer, output_buf: integer }
   pcall(vim.api.nvim_win_close, windows.input_win, true)
   pcall(vim.api.nvim_win_close, windows.output_win, true)
   pcall(vim.api.nvim_buf_delete, windows.input_buf, { force = true })
@@ -111,7 +112,7 @@ end
 function M.focus_input(opts)
   opts = opts or {}
   local windows = state.windows
-  if not windows then
+  if not windows or not windows.input_win then
     return
   end
 
@@ -130,7 +131,7 @@ end
 function M.focus_output(opts)
   opts = opts or {}
   local windows = state.windows
-  if not windows then
+  if not windows or not windows.output_win then
     return
   end
 
@@ -225,7 +226,7 @@ end
 
 function M.toggle_pane()
   local current_win = vim.api.nvim_get_current_win()
-  if current_win == state.windows.input_win then
+  if state.windows and current_win == state.windows.input_win then
     output_window.focus_output(true)
   else
     input_window.focus_input()