fix(config): add config metatable (#59)

Fixes #58

Makes config access less error prone and more ergonomic

Author: cameronr

lua/opencode/api.lua

@@ -300,7 +300,7 @@ function M.focus_input()
 end
 
 function M.debug_output()
-  local config = require('opencode.config').get()
+  local config = require('opencode.config')
   if not config.debug.enabled then
     vim.notify('Debugging is not enabled in the config', vim.log.levels.WARN)
     return
@@ -310,7 +310,7 @@ function M.debug_output()
 end
 
 function M.debug_message()
-  local config = require('opencode.config').get()
+  local config = require('opencode.config')
   if not config.debug.enabled then
     vim.notify('Debugging is not enabled in the config', vim.log.levels.WARN)
     return
@@ -320,7 +320,7 @@ function M.debug_message()
 end
 
 function M.debug_session()
-  local config = require('opencode.config').get()
+  local config = require('opencode.config')
   if not config.debug.enabled then
     vim.notify('Debugging is not enabled in the config', vim.log.levels.WARN)
     return

lua/opencode/config.lua

@@ -221,26 +221,19 @@ function M.setup(opts)
     end
   end
 
+  -- vim.notify(vim.inspect(opts))
   M.values = vim.tbl_deep_extend('force', M.values, opts --[[@as OpencodeConfig]])
+  -- vim.notify(vim.inspect(M.values))
 
   update_keymap_prefix(M.values.keymap_prefix, M.defaults.keymap_prefix)
 end
 
-function M.get(key)
-  if key then
-    return M.values[key]
-  end
-  return M.values
-end
-
 --- Get the key binding for a specific function in a scope
 --- @param scope 'editor'|'input_window'|'output_window'
 --- @param function_name string
 --- @return string|nil
 function M.get_key_for_function(scope, function_name)
-  local config_data = M.get()
-
-  local keymap_config = config_data.keymap and config_data.keymap[scope]
+  local keymap_config = M.values.keymap and M.values.keymap[scope]
   if not keymap_config then
     return nil
   end
@@ -278,4 +271,15 @@ function M.normalize_keymap(legacy_config, filter_functions)
   return converted
 end
 
-return M
+---@export Config
+return setmetatable(M, {
+  __index = function(_, key)
+    return M.values[key]
+  end,
+  __newindex = function(_, key, value)
+    M.values[key] = value
+  end,
+  __tostring = function(_)
+    return vim.inspect(M.values)
+  end,
+})

lua/opencode/context.lua

@@ -1,7 +1,7 @@
 -- Gathers editor context
 
 local util = require('opencode.util')
-local config = require('opencode.config').get()
+local config = require('opencode.config')
 local state = require('opencode.state')
 
 local M = {}

lua/opencode/core.lua

@@ -8,7 +8,7 @@ local server_job = require('opencode.server_job')
 local input_window = require('opencode.ui.input_window')
 local util = require('opencode.util')
 local Promise = require('opencode.promise')
-local config = require('opencode.config').get()
+local config = require('opencode.config')
 
 ---@param parent_id string?
 function M.select_session(parent_id)

lua/opencode/health.lua

@@ -111,34 +111,32 @@ local function check_configuration()
     return
   end
 
-  local values = config.get()
-
   local valid_positions = { 'left', 'right', 'top', 'bottom' }
-  if not vim.tbl_contains(valid_positions, values.ui.position) then
+  if not vim.tbl_contains(valid_positions, config.ui.position) then
     health.warn(
-      string.format('Invalid UI position: %s', values.ui.position),
+      string.format('Invalid UI position: %s', config.ui.position),
       { 'Valid positions: ' .. table.concat(valid_positions, ', ') }
     )
   else
-    health.ok(string.format('UI position: %s', values.ui.position))
+    health.ok(string.format('UI position: %s', config.ui.position))
   end
 
-  if values.ui.window_width <= 0 or values.ui.window_width > 1 then
+  if config.ui.window_width <= 0 or config.ui.window_width > 1 then
     health.warn(
-      string.format('Invalid window width: %s', values.ui.window_width),
+      string.format('Invalid window width: %s', config.ui.window_width),
       { 'Window width should be between 0 and 1 (percentage of screen)' }
     )
   else
-    health.ok(string.format('Window width: %s', values.ui.window_width))
+    health.ok(string.format('Window width: %s', config.ui.window_width))
   end
 
-  if values.ui.input_height <= 0 or values.ui.input_height > 1 then
+  if config.ui.input_height <= 0 or config.ui.input_height > 1 then
     health.warn(
-      string.format('Invalid input height: %s', values.ui.input_height),
+      string.format('Invalid input height: %s', config.ui.input_height),
       { 'Input height should be between 0 and 1 (percentage of screen)' }
     )
   else
-    health.ok(string.format('Input height: %s', values.ui.input_height))
+    health.ok(string.format('Input height: %s', config.ui.input_height))
   end
 
   health.ok('Configuration loaded successfully')

lua/opencode/init.lua

@@ -9,7 +9,7 @@ function M.setup(opts)
     require('opencode.core').setup()
     config.setup(opts)
     api.setup()
-    keymap.setup(config.get('keymap'))
+    keymap.setup(config.keymap)
 
     require('opencode.ui.completion').setup()
     require('opencode.event_manager').setup()

lua/opencode/keymap.lua

@@ -54,7 +54,7 @@ function M.toggle_permission_keymap(buf)
   local config = require('opencode.config')
   local api = require('opencode.api')
 
-  local permission_config = config.get().keymap.permission
+  local permission_config = config.keymap.permission
   if not permission_config then
     return
   end

lua/opencode/state.lua

@@ -1,4 +1,4 @@
-local config = require('opencode.config').get()
+local config = require('opencode.config')
 
 ---@class OpencodeWindowState
 ---@field input_win number|nil

lua/opencode/types.lua

@@ -114,7 +114,6 @@
 ---@field defaults OpencodeConfig
 ---@field values OpencodeConfig
 ---@field setup fun(opts?: OpencodeConfig): nil
----@field get fun(key?: string): any
 ---@field get_key_for_function fun(scope: 'editor'|'input_window'|'output_window', function_name: string): string|nil
 ---@field normalize_keymap fun(legacy_config: table, filter_functions?: table): table
 

lua/opencode/ui/completion.lua

@@ -63,7 +63,7 @@ function M.on_complete(item)
 end
 
 function M.get_completion_engine()
-  local config = require('opencode.config').get()
+  local config = require('opencode.config')
   local engine = config.preferred_completion
   if not engine then
     local ok_cmp = pcall(require, 'cmp')