test(replay/unit): better setup of streaming_renderer

Now that streaming_renderer uses state.active_session, have to extract
a session from the replay data

Author: cameronr

tests/helpers.lua

@@ -6,8 +6,8 @@ local M = {}
 -- Create a temporary file with content
 function M.create_temp_file(content)
   local tmp_file = vim.fn.tempname()
-  local file = io.open(tmp_file, "w")
-  file:write(content or "Test file content")
+  local file = io.open(tmp_file, 'w')
+  file:write(content or 'Test file content')
   file:close()
   return tmp_file
 end
@@ -19,21 +19,21 @@ end
 
 -- Open a buffer for a file
 function M.open_buffer(file)
-  vim.cmd("edit " .. file)
+  vim.cmd('edit ' .. file)
   return vim.api.nvim_get_current_buf()
 end
 
 -- Close a buffer
 function M.close_buffer(bufnr)
   if bufnr and vim.api.nvim_buf_is_valid(bufnr) then
-    pcall(vim.cmd, "bdelete! " .. bufnr)
+    pcall(vim.cmd, 'bdelete! ' .. bufnr)
   end
 end
 
 -- Set visual selection programmatically
 function M.set_visual_selection(start_line, start_col, end_line, end_col)
   -- Enter visual mode
-  vim.cmd("normal! " .. start_line .. "G" .. start_col .. "lv" .. end_line .. "G" .. end_col .. "l")
+  vim.cmd('normal! ' .. start_line .. 'G' .. start_col .. 'lv' .. end_line .. 'G' .. end_col .. 'l')
 end
 
 -- Reset editor state
@@ -42,11 +42,11 @@ function M.reset_editor()
   for _, bufnr in ipairs(vim.api.nvim_list_bufs()) do
     -- Skip non-existing or invalid buffers
     if vim.api.nvim_buf_is_valid(bufnr) then
-      pcall(vim.cmd, "bdelete! " .. bufnr)
+      pcall(vim.cmd, 'bdelete! ' .. bufnr)
     end
   end
   -- Reset any other editor state as needed
-  pcall(vim.cmd, "silent! %bwipeout!")
+  pcall(vim.cmd, 'silent! %bwipeout!')
 end
 
 -- Mock input function
@@ -64,15 +64,15 @@ end
 function M.mock_notify()
   local notifications = {}
   local original_notify = vim.notify
-  
+
   vim.notify = function(msg, level, opts)
     table.insert(notifications, {
       msg = msg,
       level = level,
-      opts = opts
+      opts = opts,
     })
   end
-  
+
   return {
     reset = function()
       vim.notify = original_notify
@@ -82,21 +82,21 @@ function M.mock_notify()
     end,
     clear = function()
       notifications = {}
-    end
+    end,
   }
 end
 
 function M.mock_time_ago()
   local util = require('opencode.util')
   local original_time_ago = util.time_ago
-  
+
   util.time_ago = function(timestamp)
     if timestamp > 1e12 then
       timestamp = math.floor(timestamp / 1000)
     end
     return os.date('%Y-%m-%d %H:%M:%S', timestamp)
   end
-  
+
   return function()
     util.time_ago = original_time_ago
   end
@@ -112,22 +112,37 @@ function M.load_test_data(filename)
   return vim.json.decode(content)
 end
 
+function M.get_session_from_events(events)
+  -- streaming_renderer needs a valid session id
+  for _, event in ipairs(events) do
+    -- find the session id in a message or part event
+    local properties = event.properties
+    local session_id = properties.info and properties.info.sessionID or properties.part and properties.part.sessionID
+    if session_id then
+      ---@diagnostic disable-next-line: missing-fields
+      return { id = session_id }
+    end
+  end
+
+  return nil
+end
+
 function M.replay_event(event)
   local streaming_renderer = require('opencode.ui.streaming_renderer')
   if event.type == 'message.updated' then
-    streaming_renderer.handle_message_updated(event)
+    streaming_renderer.on_message_updated(event)
   elseif event.type == 'message.part.updated' then
-    streaming_renderer.handle_part_updated(event)
+    streaming_renderer.on_part_updated(event)
   elseif event.type == 'message.removed' then
-    streaming_renderer.handle_message_removed(event)
+    streaming_renderer.on_message_removed(event)
   elseif event.type == 'message.part.removed' then
-    streaming_renderer.handle_part_removed(event)
+    streaming_renderer.on_part_removed(event)
   elseif event.type == 'session.compacted' then
-    streaming_renderer.handle_session_compacted()
+    streaming_renderer.on_session_compacted()
   elseif event.type == 'permission.updated' then
-    streaming_renderer.handle_permission_updated(event)
+    streaming_renderer.on_permission_updated(event)
   elseif event.type == 'permission.replied' then
-    streaming_renderer.handle_permission_replied(event)
+    streaming_renderer.on_permission_replied(event)
   end
 end
 
@@ -154,4 +169,4 @@ function M.capture_output(output_buf, namespace)
   }
 end
 
-return M
+return M

tests/manual/streaming_renderer_replay.lua

@@ -1,6 +1,7 @@
 local state = require('opencode.state')
 local streaming_renderer = require('opencode.ui.streaming_renderer')
 local ui = require('opencode.ui.ui')
+local config_file = require('opencode.config_file')
 local helpers = require('tests.helpers')
 
 local M = {}
@@ -34,6 +35,10 @@ function M.load_events(file_path)
   M.reset()
   M.last_loaded_file = file_path
   vim.notify('Loaded ' .. #M.events .. ' events from ' .. data_file, vim.log.levels.INFO)
+
+  ---@diagnostic disable-next-line: missing-fields
+  state.active_session = helpers.get_session_from_events(M.events)
+
   return true
 end
 
@@ -47,16 +52,16 @@ function M.setup_windows(opts)
     config.config = vim.deepcopy(config.defaults)
   end
 
-  local ok, err = pcall(function()
-    state.windows = ui.create_windows()
-  end)
+  -- disable the config_file apis because topbar uses them
+  local empty_promise = require('opencode.promise').new():resolve(nil)
+  config_file.config_promise = empty_promise
+  config_file.project_promise = empty_promise
+  config_file.providers_promise = empty_promise
 
-  if not ok then
-    vim.notify('Failed to create UI windows: ' .. tostring(err), vim.log.levels.ERROR)
-    return false
-  end
+  state.windows = ui.create_windows()
 
-  local empty_fn = function() end
+  -- we don't want output_renderer responding to setting the session id
+  require('opencode.ui.output_renderer')._cleanup_subscriptions()
 
   vim.schedule(function()
     if state.windows and state.windows.output_win then
@@ -68,9 +73,6 @@ function M.setup_windows(opts)
       end
       pcall(vim.api.nvim_buf_del_keymap, state.windows.output_buf, 'n', '<esc>')
     end
-
-    state.api_client = state.api_client or {}
-    state.api_client._call = empty_fn
   end)
 
   return true

tests/unit/streaming_renderer_spec.lua

@@ -2,14 +2,27 @@ local streaming_renderer = require('opencode.ui.streaming_renderer')
 local state = require('opencode.state')
 local ui = require('opencode.ui.ui')
 local helpers = require('tests.helpers')
+local output_renderer = require('opencode.ui.output_renderer')
+local config_file = require('opencode.config_file')
 
 describe('streaming_renderer', function()
   local restore_time_ago
 
   before_each(function()
     streaming_renderer.reset()
+
+    -- disable the config_file apis because topbar uses them
+    local empty_promise = require('opencode.promise').new():resolve(nil)
+    config_file.config_promise = empty_promise
+    config_file.project_promise = empty_promise
+    config_file.providers_promise = empty_promise
+
     state.windows = ui.create_windows()
 
+    -- we don't want output_renderer responding to setting
+    -- the session id
+    output_renderer._cleanup_subscriptions()
+
     restore_time_ago = helpers.mock_time_ago()
 
     local config = require('opencode.config')
@@ -30,6 +43,7 @@ describe('streaming_renderer', function()
 
   it('replays simple-session correctly', function()
     local events = helpers.load_test_data('tests/data/simple-session.json')
+    state.active_session = helpers.get_session_from_events(events)
     local expected = helpers.load_test_data('tests/data/simple-session.expected.json')
 
     helpers.replay_events(events)
@@ -44,6 +58,7 @@ describe('streaming_renderer', function()
 
   it('replays updating-text correctly', function()
     local events = helpers.load_test_data('tests/data/updating-text.json')
+    state.active_session = helpers.get_session_from_events(events)
     local expected = helpers.load_test_data('tests/data/updating-text.expected.json')
 
     helpers.replay_events(events)
@@ -58,6 +73,7 @@ describe('streaming_renderer', function()
 
   it('replays planning correctly', function()
     local events = helpers.load_test_data('tests/data/planning.json')
+    state.active_session = helpers.get_session_from_events(events)
     local expected = helpers.load_test_data('tests/data/planning.expected.json')
 
     helpers.replay_events(events)
@@ -72,6 +88,7 @@ describe('streaming_renderer', function()
 
   it('replays permission correctly', function()
     local events = helpers.load_test_data('tests/data/permission.json')
+    state.active_session = helpers.get_session_from_events(events)
     local expected = helpers.load_test_data('tests/data/permission.expected.json')
 
     helpers.replay_events(events)
@@ -86,6 +103,7 @@ describe('streaming_renderer', function()
 
   it('replays permission denied correctly', function()
     local events = helpers.load_test_data('tests/data/permission-denied.json')
+    state.active_session = helpers.get_session_from_events(events)
     local expected = helpers.load_test_data('tests/data/permission-denied.expected.json')
 
     helpers.replay_events(events)
@@ -100,6 +118,7 @@ describe('streaming_renderer', function()
 
   it('replays diff correctly', function()
     local events = helpers.load_test_data('tests/data/diff.json')
+    state.active_session = helpers.get_session_from_events(events)
     local expected = helpers.load_test_data('tests/data/diff.expected.json')
 
     helpers.replay_events(events)