fix(core/renderer): tune rerenders

on open, force a re-render if we're not setting a new session

in renderer, reset with the session changes, only render session
if new session isn't nil

Author: cameronr

lua/opencode/core.lua

@@ -54,19 +54,18 @@ function M.open(opts)
     state.active_session = nil
     state.last_sent_context = nil
     state.active_session = M.create_new_session()
-
-    -- FIXME: shouldn't need to clear_output here, setting the session should
-    -- do that
-    ui.clear_output()
   else
     if not state.active_session then
       state.active_session = session.get_last_workspace_session()
-    end
-
-    if (are_windows_closed or ui.is_output_empty()) and not state.display_route then
+    else
+      -- active session already set so no event will fire, need to force a refresh
       ui.render_output(true)
-      ui.scroll_to_bottom()
     end
+
+    -- if (are_windows_closed or ui.is_output_empty()) and not state.display_route then
+    --   ui.render_output(true)
+    --   ui.scroll_to_bottom()
+    -- end
   end
 
   if opts.focus == 'input' then

lua/opencode/ui/renderer.lua

@@ -28,11 +28,11 @@ end
 
 ---Set up all subscriptions, for both local and server events
 function M.setup_subscriptions(_)
-  M._subscriptions.active_session = function(_, _, old)
-    if not old then
-      return
+  M._subscriptions.active_session = function(_, new, _)
+    M.reset()
+    if new then
+      M.render_full_session()
     end
-    M.render_full_session()
   end
   state.subscribe('active_session', M._subscriptions.active_session)
   M._setup_event_subscriptions()

tests/unit/core_spec.lua

@@ -143,18 +143,8 @@ describe('opencode.core', function()
     it('handles new session properly', function()
       state.windows = nil
       state.active_session = { id = 'old-session' }
-
-      ui.clear_output:revert()
-      local cleared = false
-      stub(ui, 'clear_output').invokes(function()
-        cleared = true
-      end)
-
       core.open({ new_session = true, focus = 'input' })
       assert.truthy(state.active_session)
-      assert.is_true(cleared)
-      ui.clear_output:revert()
-      stub(ui, 'clear_output')
     end)
 
     it('focuses the appropriate window', function()