chore: more emmylua_ls / diag clean up

Author: cameronr

lua/opencode/api_client.lua

@@ -384,7 +384,7 @@ end
 --- Subscribe to events (streaming)
 --- @param directory string|nil Directory path
 --- @param on_event fun(event: table) Event callback
---- @return Job The streaming job handle
+--- @return table The streaming job handle
 function OpencodeApiClient:subscribe_to_events(directory, on_event)
   self:_ensure_base_url()
   local url = self.base_url .. '/event'

lua/opencode/promise.lua

@@ -30,7 +30,6 @@ function Promise.new()
 end
 
 ---@generic T
----@param self Promise<T>
 ---@param value T
 ---@return Promise<T>
 function Promise:resolve(value)
@@ -50,8 +49,7 @@ function Promise:resolve(value)
 end
 
 ---@generic T
----@param self Promise<T>
----@param error any
+---@param err any
 ---@return self
 function Promise:reject(err)
   if self._resolved then
@@ -70,7 +68,6 @@ function Promise:reject(err)
 end
 
 ---@generic T, U
----@param self Promise<T>
 ---@param callback fun(value: T): U | Promise<U>
 ---@return Promise<U>
 function Promise:and_then(callback)
@@ -116,7 +113,6 @@ function Promise:and_then(callback)
 end
 
 ---@generic T
----@param self Promise<T>
 ---@param error_callback fun(err: any): any | Promise<any>
 ---@return Promise<T>
 function Promise:catch(error_callback)
@@ -161,7 +157,6 @@ function Promise:catch(error_callback)
 end
 
 ---@generic T
----@param self Promise<T>
 ---@param timeout integer|nil Timeout in milliseconds (default: 5000)
 ---@param interval integer|nil Interval in milliseconds to check (default: 20)
 ---@return T

lua/opencode/provider.lua

@@ -4,6 +4,10 @@ function M._get_models()
   local config_file = require('opencode.config_file')
   local response = config_file.get_opencode_providers()
 
+  if not response then
+    return {}
+  end
+
   local models = {}
   for _, provider in ipairs(response.providers) do
     for _, model in pairs(provider.models) do

lua/opencode/ui/input_window.lua

@@ -16,7 +16,7 @@ function M._build_input_win_config()
     col = 2,
     style = 'minimal',
     zindex = 41,
-  }
+  } --[[@as vim.api.keyset.win_config]]
 end
 
 function M.create_window(windows)
@@ -41,6 +41,7 @@ function M.close()
   if not M.mounted() then
     return
   end
+  ---@cast state.windows { input_win: integer, input_buf: integer }
 
   pcall(vim.api.nvim_win_close, state.windows.input_win, true)
   pcall(vim.api.nvim_buf_delete, state.windows.input_buf, { force = true })
@@ -51,6 +52,8 @@ function M.handle_submit()
   if not windows or not M.mounted(windows) then
     return
   end
+  ---@cast windows { input_buf: integer }
+
   local input_content = table.concat(vim.api.nvim_buf_get_lines(windows.input_buf, 0, -1, false), '\n')
   vim.api.nvim_buf_set_lines(windows.input_buf, 0, -1, false, {})
   vim.api.nvim_exec_autocmds('TextChanged', {
@@ -177,6 +180,11 @@ function M.recover_input(windows)
 end
 
 function M.focus_input()
+  if not M.mounted() then
+    return
+  end
+  ---@cast state.windows { input_win: integer, input_buf: integer }
+
   vim.api.nvim_set_current_win(state.windows.input_win)
 
   local lines = vim.api.nvim_buf_get_lines(state.windows.input_buf, 0, -1, false)
@@ -192,6 +200,7 @@ function M.set_content(text, windows)
   if not M.mounted(windows) then
     return
   end
+  ---@cast windows { input_win: integer, input_buf: integer }
 
   local lines = type(text) == 'table' and text or vim.split(tostring(text), '\n')
 
@@ -212,6 +221,7 @@ function M.remove_mention(mention_name, windows)
   if not M.mounted(windows) then
     return
   end
+  ---@cast windows { input_buf: integer }
 
   local lines = vim.api.nvim_buf_get_lines(windows.input_buf, 0, -1, false)
   for i, line in ipairs(lines) do
@@ -228,12 +238,12 @@ function M.remove_mention(mention_name, windows)
 end
 
 function M.is_empty()
-  local windows = state.windows
-  if not windows or not M.mounted() then
+  if not M.mounted() then
     return true
   end
+  ---@cast state.windows { input_buf: integer }
 
-  local lines = vim.api.nvim_buf_get_lines(windows.input_buf, 0, -1, false)
+  local lines = vim.api.nvim_buf_get_lines(state.windows.input_buf, 0, -1, false)
   return #lines == 0 or (#lines == 1 and lines[1] == '')
 end
 

lua/opencode/ui/output.lua

@@ -3,7 +3,7 @@ Output.__index = Output
 
 ---@class Output
 ---@field lines string[]
----@field extmarks table<number, OutputExtmark>
+---@field extmarks table<number, OutputExtmark[]>
 ---@field actions OutputAction[]
 ---@field add_line fun(self: Output, line: string, fit?: boolean): number
 ---@field get_line fun(self: Output, idx: number): string?