fix(api): handle display_routes + rendering

Should correctly handle not loading a session when using a display_route
and then doing a refresh when we stop using one

Author: cameronr

lua/opencode/api.lua

@@ -34,7 +34,8 @@ function M.close()
   if state.display_route then
     state.display_route = nil
     ui.clear_output()
-    ui.scroll_to_bottom()
+    -- need to trigger a re-render here to re-display the session
+    ui.render_output()
     return
   end
 
@@ -266,6 +267,13 @@ function M.prev_message()
 end
 
 function M.submit_input_prompt()
+  if state.display_route then
+    -- we're displaying /help or something similar, need to clear that and refresh
+    -- the session data before sending the command
+    state.display_route = nil
+    ui.render_output()
+  end
+
   input_window.handle_submit()
 end
 

lua/opencode/core.lua

@@ -58,8 +58,12 @@ function M.open(opts)
     if not state.active_session then
       state.active_session = session.get_last_workspace_session()
     else
-      -- active session already set so no event will fire, need to force a refresh
-      ui.render_output(true)
+      if not state.display_route then
+        -- We're not displaying /help or something like that but we have an active session
+        -- so we need to do a full refresh. This mostly happens when opening the window
+        -- after having closed it since we're not currently clearing the session on api.close()
+        ui.render_output(false)
+      end
     end
 
     -- if (are_windows_closed or ui.is_output_empty()) and not state.display_route then

lua/opencode/ui/renderer.lua

@@ -109,7 +109,7 @@ function M._render_full_session_data(session_data)
       local revert_stats = M._calculate_revert_stats(state.messages, i, state.active_session.revert)
       local output = require('opencode.ui.output'):new()
       formatter._format_revert_message(output, revert_stats)
-      M.write_output(output)
+      M.render_output(output)
 
       -- FIXME: how does reverting work? why is it breaking out of the message reading loop?
       break
@@ -188,9 +188,17 @@ function M._shift_parts_and_actions(from_line, delta)
   -- vim.notify('Shifting lines from: ' .. from_line .. ' by delta: ' .. delta .. ' examined: ' .. examined .. ' shifted: ' .. shifted)
 end
 
+---Render lines as the entire output buffer
+---@param lines any
+function M.render_lines(lines)
+  local output = require('opencode.ui.output'):new()
+  output.lines = lines
+  M.render_output(output)
+end
+
 ---Sets the entire output buffer based on output_data
 ---@param output_data Output Output object from formatter
-function M.write_output(output_data)
+function M.render_output(output_data)
   if not output_window.mounted() then
     return
   end
@@ -267,17 +275,6 @@ function M._write_formatted_data(formatted_data)
   }
 end
 
----Write message header to buffer
----@param message OpencodeMessage Message object
----@param msg_idx integer Message index
----@return {line_start: integer, line_end: integer}? Range where header was written
-function M._write_message_header(message, msg_idx)
-  state.current_message = message
-  local header_data = formatter.format_message_header_single(message, msg_idx)
-  local line_range = M._write_formatted_data(header_data)
-  return line_range
-end
-
 ---Insert new part at end of buffer
 ---@param part_id string Part ID
 ---@param formatted_data Output Formatted data as Output object

lua/opencode/ui/ui.lua

@@ -198,23 +198,16 @@ function M.clear_output()
   -- state.restore_points = {}
 end
 
-function M.render_output(force)
-  force = force or false
-  -- vim.notify('render_output, force: ' .. vim.inspect(force) .. '\n' .. debug.traceback())
-  -- output_renderer.render(state.windows, force)
-
-  -- FIXME: should look at all calls of render_output and see if they're needed.
-  -- I suspect may of them can be removed and we can rely on state transitions
-  -- to handle loading
+function M.render_output(_)
   renderer.render_full_session()
 end
 
 function M.render_lines(lines)
-  -- FIXME: don't use output_renderer here
-
   M.clear_output()
-  output_renderer.write_output(state.windows, lines)
-  output_renderer.render_markdown()
+  renderer.render_lines(lines)
+
+  -- FIXME: rehook up markdown at some point (user provided callback?)
+  -- output_renderer.render_markdown()
 end
 
 function M.select_session(sessions, cb)