Skip to content

Commit 872d929

Browse files
authored
make build step for darwin builds use mac runner (#140)
use mac runner, so that the resulting binary is properly signed
1 parent a991e7c commit 872d929

File tree

2 files changed

+16
-11
lines changed

2 files changed

+16
-11
lines changed

.github/workflows/build-binaries.yml

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,20 +47,26 @@ jobs:
4747
path: dist/sea/
4848
retention-days: 1
4949

50-
# Step 2: Package per platform (cross-compilation on ubuntu)
50+
# Step 2: Package per platform
51+
# Darwin platforms must run on macOS for codesign (ad-hoc signing)
5152
package:
5253
name: Package ${{ matrix.platform }}
53-
runs-on: ubuntu-latest
54+
runs-on: ${{ matrix.runner }}
5455
needs: build
5556
strategy:
5657
fail-fast: false
5758
matrix:
58-
platform:
59-
- linux-x64
60-
- linux-x64-musl
61-
- linux-arm64
62-
- darwin-x64
63-
- darwin-arm64
59+
include:
60+
- platform: linux-x64
61+
runner: ubuntu-latest
62+
- platform: linux-x64-musl
63+
runner: ubuntu-latest
64+
- platform: linux-arm64
65+
runner: ubuntu-latest
66+
- platform: darwin-x64
67+
runner: macos-14
68+
- platform: darwin-arm64
69+
runner: macos-14
6470

6571
steps:
6672
- uses: actions/checkout@v4

.sudocode/.gitignore

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@ cache.db*
22
issues/
33
specs/
44
worktrees/
5+
config.json
56
config.local.json
67
merge-driver.log
7-
deploy-config.json
8-
spawn-config.json
98
telemetry-buffer.jsonl
10-
telemetry-flush.json
9+
telemetry-flush.json

0 commit comments

Comments
 (0)