credentials: Serve(): simplify error-handling logic

Don't use an err if we can print the error immediately :)

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Author: thaJeztah

credentials/credentials.go

@@ -49,21 +49,21 @@ func SetCredsLabel(label string) {
 // It uses os.Stdin as input and os.Stdout as output.
 // This function terminates the program with os.Exit(1) if there is an error.
 func Serve(helper Helper) {
-	var err error
 	if len(os.Args) != 2 {
-		err = fmt.Errorf("Usage: %s <store|get|erase|list|version>", Name)
-	}
-
-	if err == nil {
-		err = HandleCommand(helper, os.Args[1], os.Stdin, os.Stdout)
+		_, _ = fmt.Fprintln(os.Stdout, usage())
+		os.Exit(1)
 	}
 
-	if err != nil {
+	if err := HandleCommand(helper, os.Args[1], os.Stdin, os.Stdout); err != nil {
 		_, _ = fmt.Fprintln(os.Stdout, err)
 		os.Exit(1)
 	}
 }
 
+func usage() string {
+	return fmt.Sprintf("Usage: %s <store|get|erase|list|version>", Name)
+}
+
 // HandleCommand uses a helper and a key to run a credential action.
 func HandleCommand(helper Helper, key string, in io.Reader, out io.Writer) error {
 	switch key {