[FLINK-37168][python] clean up TimerRegistrationAction in a thread-safe manner in unregisteredTimers list after timers are registered

Author: suez1224

flink-python/pyflink/.idea/.gitignore

@@ -18,6 +18,9 @@
 
 package org.apache.flink.streaming.api.operators.python.process.timer;
 
+import java.util.List;
+
+/** {@link TimerRegistrationAction} used to register Timer. */
 public class TimerRegistrationAction {
 
     private final TimerRegistration timerRegistration;
@@ -26,16 +29,22 @@ public class TimerRegistrationAction {
 
     private boolean isRegistered;
 
+    private final List<TimerRegistrationAction> containingList;
+
     public TimerRegistrationAction(
-            TimerRegistration timerRegistration, byte[] serializedTimerData) {
+            TimerRegistration timerRegistration,
+            byte[] serializedTimerData,
+            List<TimerRegistrationAction> containingList) {
         this.timerRegistration = timerRegistration;
         this.serializedTimerData = serializedTimerData;
+        this.containingList = containingList;
         this.isRegistered = false;
     }
 
     public void run() {
         if (!isRegistered) {
             timerRegistration.setTimer(serializedTimerData);
+            containingList.remove(this);
             isRegistered = true;
         }
     }

flink-python/pyflink/.idea/inspectionProfiles/profiles_settings.xml

@@ -195,7 +195,7 @@ public abstract class BeamPythonFunctionRunner implements PythonFunctionRunner {
 
     private transient Environment environment;
 
-    private transient List<TimerRegistrationAction> unregisteredTimers;
+    private transient volatile List<TimerRegistrationAction> unregisteredTimers;
 
     public BeamPythonFunctionRunner(
             Environment environment,
@@ -311,7 +311,7 @@ public void open(ReadableConfig config) throws Exception {
                 ShutdownHookUtil.addShutdownHook(
                         this, BeamPythonFunctionRunner.class.getSimpleName(), LOG);
 
-        unregisteredTimers = new LinkedList<>();
+        unregisteredTimers = Collections.synchronizedList(new LinkedList<>());
     }
 
     @Override
@@ -352,8 +352,10 @@ public void process(byte[] data) throws Exception {
 
     @Override
     public void drainUnregisteredTimers() {
-        for (TimerRegistrationAction timerRegistrationAction : unregisteredTimers) {
-            timerRegistrationAction.run();
+        synchronized (unregisteredTimers) {
+            for (TimerRegistrationAction timerRegistrationAction : unregisteredTimers) {
+                timerRegistrationAction.run();
+            }
         }
         unregisteredTimers.clear();
     }
@@ -703,7 +705,9 @@ private TimerReceiverFactory createTimerReceiverFactory() {
                 (timer, timerData) -> {
                     TimerRegistrationAction timerRegistrationAction =
                             new TimerRegistrationAction(
-                                    timerRegistration, (byte[]) timer.getUserKey());
+                                    timerRegistration,
+                                    (byte[]) timer.getUserKey(),
+                                    unregisteredTimers);
                     unregisteredTimers.add(timerRegistrationAction);
                     environment
                             .getMainMailboxExecutor()