Simplify tests with better naming

Author: simonsmith

test/test.js

@@ -163,53 +163,50 @@ describe('suitcss', function() {
       });
     });
 
-    describe('beforeLint option', function() {
-      var lintImportedFilesStub, bemLintStub, beforeLintStub, revert;
+    describe('transforming css before linting', function() {
+      var lintImportedFilesStub, beforeLintStub, revert;
 
       beforeEach(function() {
-        lintImportedFilesStub = sinon.stub();
-        bemLintStub = sinon.stub().returns('/* lint */');
-        beforeLintStub = sinon.stub().returns('/* before lint */');
-
-        lintImportedFilesStub.onFirstCall().returns(bemLintStub);
+        lintImportedFilesStub = sinon.stub().returns('/*linting done*/');
+        beforeLintStub = sinon.stub().returns('/*before lint*/');
         revert = suitcss.__set__('lintImportedFiles', lintImportedFilesStub);
       });
 
       afterEach(function() {
         revert();
       });
 
-      it('should call user supplied function before linting', function(done) {
+      it('should call `beforeLint` function before linting', function(done) {
         suitcss(read('fixtures/component'), {
           root: 'test/fixtures',
           beforeLint: beforeLintStub
         }).catch(done);
 
-        expect(bemLintStub.calledOnce).to.be.ok;
-        expect(beforeLintStub.calledOnce).to.be.ok;
-        expect(beforeLintStub.calledBefore(bemLintStub)).to.be.ok;
+        expect(lintImportedFilesStub.calledOnce).to.be.true;
+        expect(beforeLintStub.calledOnce).to.be.true;
+        expect(beforeLintStub.calledBefore(lintImportedFilesStub)).to.be.true;
 
         done();
       });
 
-      it('should pass processed CSS to the linting transform function', function(done) {
+      it('should pass the result of `beforeLint` to `lintImportedFiles`', function(done) {
         suitcss(read('fixtures/component'), {
           root: 'test/fixtures',
           beforeLint: beforeLintStub
         }).catch(done);
 
-        expect(bemLintStub.args[0][0]).to.equal('/* before lint */');
+        expect(lintImportedFilesStub.args[0][1]).to.equal('/*before lint*/');
 
         done();
       });
 
-      it('should pass the merged options to the beforeLint function', function(done) {
+      it('should pass the options object to the beforeLint function as the third parameter', function(done) {
         suitcss(read('fixtures/component'), {
           root: 'test/fixtures',
           beforeLint: beforeLintStub
         }).catch(done);
 
-        expect(beforeLintStub.args[0][2].root).to.equal('test/fixtures');
+        expect(beforeLintStub.args[0][2]).to.contain({root: 'test/fixtures'});
 
         done();
       });