Skip to content

Commit 07d9e29

Browse files
committed
✅(backend) adapt test to djangorestframework 3.15.2
A recent update of the djangorestframework changes the detail message of the 404 error. We update the tests to match the new message.
1 parent 29c5199 commit 07d9e29

8 files changed

+21
-17
lines changed

src/backend/core/tests/documents/test_api_document_accesses.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,9 @@ def test_api_document_accesses_retrieve_authenticated_unrelated():
173173
)
174174

175175
assert response.status_code == 404
176-
assert response.json() == {"detail": "Not found."}
176+
assert response.json() == {
177+
"detail": "No DocumentAccess matches the given query."
178+
}
177179

178180

179181
@pytest.mark.parametrize("via", VIA)

src/backend/core/tests/documents/test_api_document_versions.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def test_api_document_versions_list_anonymous_private():
3838
response = APIClient().get(f"/api/v1.0/documents/{document.id!s}/versions/")
3939

4040
assert response.status_code == 404
41-
assert response.json() == {"detail": "Not found."}
41+
assert response.json() == {"detail": "No Document matches the given query."}
4242

4343

4444
def test_api_document_versions_list_authenticated_unrelated_public():
@@ -86,7 +86,7 @@ def test_api_document_versions_list_authenticated_unrelated_private():
8686
f"/api/v1.0/documents/{document.id!s}/versions/",
8787
)
8888
assert response.status_code == 404
89-
assert response.json() == {"detail": "Not found."}
89+
assert response.json() == {"detail": "No Document matches the given query."}
9090

9191

9292
@pytest.mark.parametrize("via", VIA)
@@ -169,7 +169,7 @@ def test_api_document_versions_retrieve_anonymous_private():
169169
response = APIClient().get(url)
170170

171171
assert response.status_code == 404
172-
assert response.json() == {"detail": "Not found."}
172+
assert response.json() == {"detail": "No Document matches the given query."}
173173

174174

175175
def test_api_document_versions_retrieve_authenticated_unrelated_public():
@@ -211,7 +211,7 @@ def test_api_document_versions_retrieve_authenticated_unrelated_private():
211211
f"/api/v1.0/documents/{document.id!s}/versions/{version_id:s}/",
212212
)
213213
assert response.status_code == 404
214-
assert response.json() == {"detail": "Not found."}
214+
assert response.json() == {"detail": "No Document matches the given query."}
215215

216216

217217
@pytest.mark.parametrize("via", VIA)
@@ -434,7 +434,7 @@ def test_api_document_versions_delete_authenticated_private():
434434
)
435435

436436
assert response.status_code == 404
437-
assert response.json() == {"detail": "Not found."}
437+
assert response.json() == {"detail": "No Document matches the given query."}
438438

439439

440440
@pytest.mark.parametrize("role", ["reader", "editor"])

src/backend/core/tests/documents/test_api_documents_retrieve.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def test_api_documents_retrieve_anonymous_not_public():
4545
response = APIClient().get(f"/api/v1.0/documents/{document.id!s}/")
4646

4747
assert response.status_code == 404
48-
assert response.json() == {"detail": "Not found."}
48+
assert response.json() == {"detail": "No Document matches the given query."}
4949

5050

5151
def test_api_documents_retrieve_authenticated_unrelated_public():
@@ -101,7 +101,7 @@ def test_api_documents_retrieve_authenticated_unrelated_not_public():
101101
f"/api/v1.0/documents/{document.id!s}/",
102102
)
103103
assert response.status_code == 404
104-
assert response.json() == {"detail": "Not found."}
104+
assert response.json() == {"detail": "No Document matches the given query."}
105105

106106

107107
def test_api_documents_retrieve_authenticated_related_direct():
@@ -184,7 +184,7 @@ def test_api_documents_retrieve_authenticated_related_team_none(mock_user_get_te
184184

185185
response = client.get(f"/api/v1.0/documents/{document.id!s}/")
186186
assert response.status_code == 404
187-
assert response.json() == {"detail": "Not found."}
187+
assert response.json() == {"detail": "No Document matches the given query."}
188188

189189

190190
@pytest.mark.parametrize(

src/backend/core/tests/documents/test_api_documents_update.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def test_api_documents_update_authenticated_unrelated():
5858
)
5959

6060
assert response.status_code == 404
61-
assert response.json() == {"detail": "Not found."}
61+
assert response.json() == {"detail": "No Document matches the given query."}
6262

6363
document.refresh_from_db()
6464
document_values = serializers.DocumentSerializer(instance=document).data

src/backend/core/tests/templates/test_api_templates_generate_document.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def test_api_templates_generate_document_anonymous_not_public():
4444
)
4545

4646
assert response.status_code == 404
47-
assert response.json() == {"detail": "Not found."}
47+
assert response.json() == {"detail": "No Template matches the given query."}
4848

4949

5050
def test_api_templates_generate_document_authenticated_public():
@@ -87,7 +87,7 @@ def test_api_templates_generate_document_authenticated_not_public():
8787
)
8888

8989
assert response.status_code == 404
90-
assert response.json() == {"detail": "Not found."}
90+
assert response.json() == {"detail": "No Template matches the given query."}
9191

9292

9393
@pytest.mark.parametrize("via", VIA)

src/backend/core/tests/templates/test_api_templates_retrieve.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def test_api_templates_retrieve_anonymous_not_public():
4141
response = APIClient().get(f"/api/v1.0/templates/{template.id!s}/")
4242

4343
assert response.status_code == 404
44-
assert response.json() == {"detail": "Not found."}
44+
assert response.json() == {"detail": "No Template matches the given query."}
4545

4646

4747
def test_api_templates_retrieve_authenticated_unrelated_public():
@@ -94,7 +94,7 @@ def test_api_templates_retrieve_authenticated_unrelated_not_public():
9494
f"/api/v1.0/templates/{template.id!s}/",
9595
)
9696
assert response.status_code == 404
97-
assert response.json() == {"detail": "Not found."}
97+
assert response.json() == {"detail": "No Template matches the given query."}
9898

9999

100100
def test_api_templates_retrieve_authenticated_related_direct():
@@ -174,7 +174,7 @@ def test_api_templates_retrieve_authenticated_related_team_none(mock_user_get_te
174174

175175
response = client.get(f"/api/v1.0/templates/{template.id!s}/")
176176
assert response.status_code == 404
177-
assert response.json() == {"detail": "Not found."}
177+
assert response.json() == {"detail": "No Template matches the given query."}
178178

179179

180180
@pytest.mark.parametrize(

src/backend/core/tests/templates/test_api_templates_update.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def test_api_templates_update_authenticated_unrelated():
5858
)
5959

6060
assert response.status_code == 404
61-
assert response.json() == {"detail": "Not found."}
61+
assert response.json() == {"detail": "No Template matches the given query."}
6262

6363
template.refresh_from_db()
6464
template_values = serializers.TemplateSerializer(instance=template).data

src/backend/core/tests/test_api_template_accesses.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,9 @@ def test_api_template_accesses_retrieve_authenticated_unrelated():
170170
)
171171

172172
assert response.status_code == 404
173-
assert response.json() == {"detail": "Not found."}
173+
assert response.json() == {
174+
"detail": "No TemplateAccess matches the given query."
175+
}
174176

175177

176178
@pytest.mark.parametrize("via", VIA)

0 commit comments

Comments
 (0)