Skip to content

Commit 12ef1a2

Browse files
committed
🚩(backend) default enable FRONTEND_HOMEPAGE_FEATURE_ENABLED
We decided to enable the FRONTEND_HOMEPAGE_FEATURE_ENABLED feature flag by default. It will not be a breaking change like that.
1 parent 9b2f796 commit 12ef1a2

File tree

4 files changed

+1
-4
lines changed

4 files changed

+1
-4
lines changed

env.d/development/common.dist

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,5 @@ COLLABORATION_WS_URL=ws://localhost:4444/collaboration/ws/
6464

6565
# Frontend
6666
FRONTEND_THEME=default
67-
FRONTEND_HOMEPAGE_FEATURE_ENABLED=True
6867
FRONTEND_FOOTER_FEATURE_ENABLED=True
6968
FRONTEND_URL_JSON_FOOTER=http://frontend:3000/contents/footer-demo.json

src/backend/core/tests/test_api_config.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
COLLABORATION_WS_URL="http://testcollab/",
2020
CRISP_WEBSITE_ID="123",
2121
FRONTEND_CSS_URL="http://testcss/",
22-
FRONTEND_HOMEPAGE_FEATURE_ENABLED=True,
2322
FRONTEND_FOOTER_FEATURE_ENABLED=True,
2423
FRONTEND_THEME="test-theme",
2524
MEDIA_BASE_URL="http://testserver/",

src/backend/impress/settings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,7 @@ class Base(Configuration):
418418
None, environ_name="FRONTEND_THEME", environ_prefix=None
419419
)
420420
FRONTEND_HOMEPAGE_FEATURE_ENABLED = values.BooleanValue(
421-
default=False,
421+
default=True,
422422
environ_name="FRONTEND_HOMEPAGE_FEATURE_ENABLED",
423423
environ_prefix=None,
424424
)

src/helm/env.d/dev/values.impress.yaml.gotmpl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ backend:
5050
DB_USER: dinum
5151
DB_PASSWORD: pass
5252
DB_PORT: 5432
53-
FRONTEND_HOMEPAGE_FEATURE_ENABLED: true
5453
FRONTEND_FOOTER_FEATURE_ENABLED: true
5554
FRONTEND_URL_JSON_FOOTER: https://impress.127.0.0.1.nip.io/contents/footer-demo.json
5655
POSTGRES_DB: impress

0 commit comments

Comments
 (0)