🐛 remove add row magic string

Author: anaisberg

src/frontend/apps/impress/src/features/docs/doc-editor/components/custom-blocks/DatabaseBlock/DatabaseGrid.tsx

@@ -13,6 +13,7 @@ import { AddButtonComponent } from './AddColumnButton';
 import { useColumns, useRows } from './hooks';
 import { DatabaseRow } from './types';
 import {
+  ADD_NEW_ROW,
   addRowCellRenderer,
   createNewRow,
   getColumnNames,
@@ -72,9 +73,17 @@ export const DatabaseGrid = ({
 
   useEffect(() => {
     const columnNames = getColumnNames(colDefs);
-    const addNewRow = createNewRow({ value: '+ new  row', columnNames });
+    const lastRow = rowData?.[rowData.length - 1];
+    if (lastRow && Object.values(lastRow).length > 0) {
+      const lastRowValue = Object.values(lastRow)[0];
+      if (lastRowValue === ADD_NEW_ROW) {
+        return;
+      }
+    }
+    const addNewRow = createNewRow({ value: ADD_NEW_ROW, columnNames });
     setRowData((prev) => [...(prev ? prev : []), addNewRow]);
-  }, [colDefs, setRowData]);
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [colDefs]);
 
   const defaultColDef = {
     flex: 1,

src/frontend/apps/impress/src/features/docs/doc-editor/components/custom-blocks/DatabaseBlock/utils.ts

@@ -9,6 +9,8 @@ import { Dispatch, SetStateAction } from 'react';
 import { AddRowButton } from './AddRowButton';
 import { DatabaseRow } from './types';
 
+export const ADD_NEW_ROW = 'add-new-row';
+
 export const autoSizeStrategy: SizeColumnsToContentStrategy = {
   type: 'fitCellContents',
 };
@@ -40,7 +42,7 @@ export const addRowCellRenderer = (
       component: AddRowButton,
       params: { columns, setRowData },
     };
-    if (Object.values(params.data)[0]?.includes('new')) {
+    if (Object.values(params.data)[0] === ADD_NEW_ROW) {
       return addRowButton;
     }
     return undefined;
@@ -52,7 +54,7 @@ export const newRowColSpan = (
   params: ColSpanParams<Record<string, string>>,
 ) => {
   const colsValues = params.data ?? {};
-  const isNewRow = Object.values(colsValues)[0]?.includes('new');
+  const isNewRow = Object.values(colsValues)[0] === ADD_NEW_ROW;
   if (isNewRow) {
     return Object.keys(colsValues).length;
   }