Skip to content

Commit 3827f0f

Browse files
committed
🩹(frontend) fine tuning v2.2.0
Fix minor issues: - Add some height to the carret in the editor - Improve css in mail templates - Improve images resolution on homepage
1 parent d89e3dc commit 3827f0f

File tree

21 files changed

+14
-15
lines changed

21 files changed

+14
-15
lines changed

src/frontend/apps/e2e/__tests__/app-impress/header.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ test.describe('Header', () => {
1010
test('checks all the elements are visible', async ({ page }) => {
1111
const header = page.locator('header').first();
1212

13-
await expect(header.getByAltText('Docs Logo')).toBeVisible();
13+
await expect(header.getByLabel('Docs Logo')).toBeVisible();
1414
await expect(header.locator('h2').getByText('Docs')).toHaveCSS(
1515
'color',
1616
'rgb(0, 0, 145)',

src/frontend/apps/impress/src/features/auth/components/ButtonLogin.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
import { Button } from '@openfun/cunningham-react';
2-
import Image from 'next/image';
32
import { useTranslation } from 'react-i18next';
43
import { css } from 'styled-components';
54

65
import { BoxButton } from '@/components';
76

8-
import ProConnectImg from '../assets/button-proconnect.svg?url';
7+
import ProConnectImg from '../assets/button-proconnect.svg';
98
import { useAuth } from '../hooks';
109
import { gotoLogin, gotoLogout } from '../utils';
1110

@@ -41,8 +40,9 @@ export const ProConnectButton = () => {
4140
background-color: var(--c--theme--colors--primary-action);
4241
}
4342
`}
43+
$radius="4px"
4444
>
45-
<Image src={ProConnectImg} alt={t('ProConnect Image')} />
45+
<ProConnectImg />
4646
</BoxButton>
4747
);
4848
};

src/frontend/apps/impress/src/features/docs/doc-editor/components/DocEditor.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export const DocEditor = ({ doc, versionId }: DocEditorProps) => {
6565
$css="overflow-x: clip; flex: 1;"
6666
$position="relative"
6767
>
68-
<Box $css="flex:1;" $position="relative">
68+
<Box $css="flex:1;" $position="relative" $width="100%">
6969
{isVersion ? (
7070
<DocVersionEditor docId={doc.id} versionId={versionId} />
7171
) : (

src/frontend/apps/impress/src/features/docs/doc-editor/styles.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export const cssEditor = (readonly: boolean) => css`
1111
}
1212
.collaboration-cursor-custom__caret {
1313
position: absolute;
14-
height: 85%;
14+
height: 100%;
1515
width: 2px;
1616
bottom: 4%;
1717
left: -1px;

src/frontend/apps/impress/src/features/header/components/Header.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
import Image from 'next/image';
21
import { useTranslation } from 'react-i18next';
32
import { css } from 'styled-components';
43

5-
import { default as IconDocs } from '@/assets/icons/icon-docs.svg?url';
4+
import IconDocs from '@/assets/icons/icon-docs.svg';
65
import { Box, StyledLink } from '@/components/';
76
import { useCunninghamTheme } from '@/cunningham';
87
import { ButtonLogin } from '@/features/auth';
@@ -51,7 +50,7 @@ export const Header = () => {
5150
$height="fit-content"
5251
$margin={{ top: 'auto' }}
5352
>
54-
<Image priority src={IconDocs} alt={t('Docs Logo')} width={25} />
53+
<IconDocs aria-label={t('Docs Logo')} width={25} />
5554
<Title />
5655
</Box>
5756
</StyledLink>
59.1 KB
Loading
73.6 KB
Loading
14.4 KB
Loading
14.5 KB
Loading
34.3 KB
Loading

0 commit comments

Comments
 (0)