Skip to content

Commit 3e5f27c

Browse files
dominikkaminskiAntoLC
authored andcommitted
🔧(helm) add option to disable default tls setting
Sets an option for those who uses impress with a different secretName in ingress.
1 parent f2f64f7 commit 3e5f27c

File tree

7 files changed

+29
-18
lines changed

7 files changed

+29
-18
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ and this project adheres to
99

1010
## [Unreleased]
1111

12+
## Added
13+
14+
🔧(helm) add option to disable default tls setting by @dominikkaminski #519
15+
1216

1317
## [1.10.0] - 2024-12-17
1418

src/helm/impress/templates/ingress.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ spec:
2929
{{- if .Values.ingress.tls.enabled }}
3030
tls:
3131
{{- if .Values.ingress.host }}
32-
- secretName: {{ $fullName }}-tls
32+
- secretName: {{ .Values.ingress.tls.secretName | default (printf "%s-tls" $fullName) | quote }}
3333
hosts:
3434
- {{ .Values.ingress.host | quote }}
3535
{{- end }}
@@ -115,4 +115,3 @@ spec:
115115
{{- end }}
116116
{{- end }}
117117
{{- end }}
118-

src/helm/impress/templates/ingress_admin.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ spec:
2929
{{- if .Values.ingressAdmin.tls.enabled }}
3030
tls:
3131
{{- if .Values.ingressAdmin.host }}
32-
- secretName: {{ $fullName }}-tls
32+
- secretName: {{ .Values.ingressAdmin.tls.secretName | default (printf "%s-tls" $fullName) | quote }}
3333
hosts:
3434
- {{ .Values.ingressAdmin.host | quote }}
3535
{{- end }}
@@ -95,4 +95,3 @@ spec:
9595
{{- end }}
9696
{{- end }}
9797
{{- end }}
98-

src/helm/impress/templates/ingress_collaboration_api.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ spec:
2929
{{- if .Values.ingressCollaborationApi.tls.enabled }}
3030
tls:
3131
{{- if .Values.ingressCollaborationApi.host }}
32-
- secretName: {{ $fullName }}-tls
32+
- secretName: {{ .Values.ingressCollaborationApi.tls.secretName | default (printf "%s-tls" $fullName) | quote }}
3333
hosts:
3434
- {{ .Values.ingressCollaborationApi.host | quote }}
3535
{{- end }}
@@ -69,4 +69,3 @@ spec:
6969
{{- end }}
7070
{{- end }}
7171
{{- end }}
72-

src/helm/impress/templates/ingress_collaboration_ws.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ spec:
2929
{{- if .Values.ingressCollaborationWS.tls.enabled }}
3030
tls:
3131
{{- if .Values.ingressCollaborationWS.host }}
32-
- secretName: {{ $fullName }}-tls
32+
- secretName: {{ .Values.ingressCollaborationWS.tls.secretName | default (printf "%s-tls" $fullName) | quote }}
3333
hosts:
3434
- {{ .Values.ingressCollaborationWS.host | quote }}
3535
{{- end }}
@@ -69,4 +69,3 @@ spec:
6969
{{- end }}
7070
{{- end }}
7171
{{- end }}
72-

src/helm/impress/templates/ingress_media.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ spec:
2929
{{- if .Values.ingressMedia.tls.enabled }}
3030
tls:
3131
{{- if .Values.ingressMedia.host }}
32-
- secretName: {{ $fullName }}-tls
32+
- secretName: {{ .Values.ingressMedia.tls.secretName | default (printf "%s-tls" $fullName) | quote }}
3333
hosts:
3434
- {{ .Values.ingressMedia.host | quote }}
3535
{{- end }}

src/helm/impress/values.yaml

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,14 @@ ingress:
3737
## @param ingress.hosts Additional host to configure for the Ingress
3838
hosts: []
3939
# - chart-example.local
40-
## @param ingress.tls.enabled Wether to enable TLS for the Ingress
40+
## @param ingress.tls.enabled Weather to enable TLS for the Ingress
41+
## @param ingress.tls.secretName Secret name for TLS config
4142
## @skip ingress.tls.additional
4243
## @extra ingress.tls.additional[].secretName Secret name for additional TLS config
4344
## @extra ingress.tls.additional[].hosts[] Hosts for additional TLS config
4445
tls:
4546
enabled: true
47+
secretName: null
4648
additional: []
4749

4850
## @param ingress.customBackends Add custom backends to ingress
@@ -60,21 +62,23 @@ ingressCollaborationWS:
6062
## @param ingress.hosts Additional host to configure for the Ingress
6163
hosts: []
6264
# - chart-example.local
63-
## @param ingressCollaborationWS.tls.enabled Wether to enable TLS for the Ingress
65+
## @param ingressCollaborationWS.tls.enabled Weather to enable TLS for the Ingress
66+
## @param ingressCollaborationWS.tls.secretName Secret name for TLS config
6467
## @skip ingressCollaborationWS.tls.additional
6568
## @extra ingressCollaborationWS.tls.additional[].secretName Secret name for additional TLS config
6669
## @extra ingressCollaborationWS.tls.additional[].hosts[] Hosts for additional TLS config
6770
tls:
6871
enabled: true
72+
secretName: null
6973
additional: []
7074

7175
## @param ingressCollaborationWS.customBackends Add custom backends to ingress
7276
customBackends: []
7377

74-
annotations:
78+
annotations:
7579
nginx.ingress.kubernetes.io/auth-response-headers: "Authorization, X-Can-Edit, X-User-Id"
7680
nginx.ingress.kubernetes.io/auth-url: https://impress.example.com/api/v1.0/documents/collaboration-auth/
77-
nginx.ingress.kubernetes.io/enable-websocket: "true"
81+
nginx.ingress.kubernetes.io/enable-websocket: "true"
7882
nginx.ingress.kubernetes.io/proxy-read-timeout: "86400"
7983
nginx.ingress.kubernetes.io/proxy-send-timeout: "86400"
8084
nginx.ingress.kubernetes.io/upstream-hash-by: $arg_room
@@ -91,20 +95,23 @@ ingressCollaborationApi:
9195
## @param ingress.hosts Additional host to configure for the Ingress
9296
hosts: []
9397
# - chart-example.local
94-
## @param ingressCollaborationApi.tls.enabled Wether to enable TLS for the Ingress
98+
## @param ingressCollaborationApi.tls.enabled Weather to enable TLS for the Ingress
99+
## @param ingressCollaborationApi.tls.secretName Secret name for TLS config
95100
## @skip ingressCollaborationApi.tls.additional
96101
## @extra ingressCollaborationApi.tls.additional[].secretName Secret name for additional TLS config
97102
## @extra ingressCollaborationApi.tls.additional[].hosts[] Hosts for additional TLS config
98103
tls:
99104
enabled: true
105+
secretName: null
100106
additional: []
101107

102108
## @param ingressCollaborationApi.customBackends Add custom backends to ingress
103109
customBackends: []
104110

105-
annotations:
111+
annotations:
106112
nginx.ingress.kubernetes.io/upstream-hash-by: $arg_room
107113

114+
108115
## @param ingressAdmin.enabled whether to enable the Ingress or not
109116
## @param ingressAdmin.className IngressClass to use for the Ingress
110117
## @param ingressAdmin.host Host for the Ingress
@@ -117,12 +124,14 @@ ingressAdmin:
117124
## @param ingressAdmin.hosts Additional host to configure for the Ingress
118125
hosts: [ ]
119126
# - chart-example.local
120-
## @param ingressAdmin.tls.enabled Wether to enable TLS for the Ingress
127+
## @param ingressAdmin.tls.enabled Weather to enable TLS for the Ingress
128+
## @param ingressAdmin.tls.secretName Secret name for TLS config
121129
## @skip ingressAdmin.tls.additional
122130
## @extra ingressAdmin.tls.additional[].secretName Secret name for additional TLS config
123131
## @extra ingressAdmin.tls.additional[].hosts[] Hosts for additional TLS config
124132
tls:
125133
enabled: true
134+
secretName: null
126135
additional: []
127136

128137
## @param ingressMedia.enabled whether to enable the Ingress or not
@@ -137,12 +146,14 @@ ingressMedia:
137146
## @param ingressMedia.hosts Additional host to configure for the Ingress
138147
hosts: [ ]
139148
# - chart-example.local
140-
## @param ingressMedia.tls.enabled Wether to enable TLS for the Ingress
149+
## @param ingressMedia.tls.enabled Weather to enable TLS for the Ingress
150+
## @param ingressMedia.tls.secretName Secret name for TLS config
141151
## @skip ingressMedia.tls.additional
142152
## @extra ingressMedia.tls.additional[].secretName Secret name for additional TLS config
143153
## @extra ingressMedia.tls.additional[].hosts[] Hosts for additional TLS config
144154
tls:
145155
enabled: true
156+
secretName: null
146157
additional: []
147158

148159
annotations:
@@ -442,4 +453,4 @@ yProvider:
442453
extraVolumeMounts: []
443454

444455
## @param yProvider.extraVolumes Additional volumes to mount on the yProvider.
445-
extraVolumes: []
456+
extraVolumes: []

0 commit comments

Comments
 (0)