🎨(frontend) Minor refactoring

- improve condition statements
- add "no-var" rule in eslint
- remove some unnecessary variables

Signed-off-by: Zorin95670 <[email protected]>

Author: Zorin95670

src/frontend/apps/impress/next.config.js

@@ -48,10 +48,7 @@ const nextConfig = {
           swDest: '../public/service-worker.js',
           include: [
             ({ asset }) => {
-              if (asset.name.match(/.*(static).*/)) {
-                return true;
-              }
-              return false;
+              return !!asset.name.match(/.*(static).*/);
             },
           ],
         }),

src/frontend/apps/impress/src/api/fetchApi.ts

@@ -23,11 +23,9 @@ export const fetchAPI = async (
     delete headers?.['Content-Type' as keyof typeof headers];
   }
 
-  const response = await fetch(apiUrl, {
+  return await fetch(apiUrl, {
     ...init,
     credentials: 'include',
     headers,
   });
-
-  return response;
 };

src/frontend/apps/impress/src/core/AppProvider.tsx

@@ -35,8 +35,7 @@ export function AppProvider({ children }: { children: React.ReactNode }) {
   );
 
   useEffect(() => {
-    const cleanupResizeListener = initializeResizeListener();
-    return cleanupResizeListener;
+    return initializeResizeListener();
   }, [initializeResizeListener]);
 
   useEffect(() => {

src/frontend/apps/impress/src/core/config/api/useConfig.tsx

@@ -53,13 +53,11 @@ export function useConfig() {
   const cachedData = getCachedTranslation();
   const oneHour = 1000 * 60 * 60;
 
-  const response = useQuery<ConfigResponse, APIError, ConfigResponse>({
+  return useQuery<ConfigResponse, APIError, ConfigResponse>({
     queryKey: [KEY_CONFIG],
     queryFn: () => getConfig(),
     initialData: cachedData,
     staleTime: oneHour,
     initialDataUpdatedAt: Date.now() - oneHour, // Force initial data to be considered stale
   });
-
-  return response;
 }

src/frontend/apps/impress/src/features/docs/doc-editor/hook/useSaveDoc.tsx

@@ -31,7 +31,7 @@ const useSaveDoc = (docId: string, yDoc: Y.Doc, canSave: boolean) => {
       _updatedDoc: Y.Doc,
       transaction: Y.Transaction,
     ) => {
-      setIsLocalChange(transaction.local ? true : false);
+      setIsLocalChange(transaction.local);
     };
 
     yDoc.on('update', onUpdate);

src/frontend/apps/impress/src/services/PosthogAnalytic.tsx

@@ -25,14 +25,10 @@ export class PostHogAnalytic extends AbstractAnalytic {
   }
 
   public isFeatureFlagActivated(flagName: string): boolean {
-    if (
+    return !(
       posthog.featureFlags.getFlags().includes(flagName) &&
       posthog.isFeatureEnabled(flagName) === false
-    ) {
-      return false;
-    }
-
-    return true;
+    );
   }
 }
 

src/frontend/apps/impress/src/utils/url.ts

@@ -40,11 +40,7 @@ export function isSafeUrl(url: string): boolean {
     }
 
     // Check for directory traversal attempts
-    if (url.includes('..') || url.includes('../') || url.includes('..\\')) {
-      return false;
-    }
-
-    return true;
+    return !(url.includes('..') || url.includes('../') || url.includes('..\\'));
   } catch {
     return false;
   }

src/frontend/packages/eslint-config-impress/common.js

@@ -56,6 +56,7 @@ const globalRules = {
     'error',
     { varsIgnorePattern: '^_', argsIgnorePattern: '^_' },
   ],
+  'no-var': 'error',
   'react/jsx-curly-brace-presence': [
     'error',
     { props: 'never', children: 'never', propElementValues: 'always' },

src/frontend/servers/y-provider/.eslintrc.cjs

@@ -13,5 +13,5 @@ module.exports = {
   rules: {
     '@next/next/no-html-link-for-pages': 'off',
   },
-  ignorePatterns: ['node_modules', '.eslintrc.js'],
+  ignorePatterns: ['node_modules'],
 };

src/frontend/servers/y-provider/jest.config.js

@@ -1,4 +1,4 @@
-var config = {
+const config = {
   rootDir: './__tests__',
   testEnvironment: 'node',
   transform: {