Skip to content

Commit 76c2876

Browse files
committed
🔥(back) remove footer endpoint
With the configuration file, the footer endpoint can be removed and will not be used anymore by the front application.
1 parent d856abb commit 76c2876

File tree

13 files changed

+6
-386
lines changed

13 files changed

+6
-386
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ and this project adheres to
2020
- 📝(frontend) Update documentation
2121
- ✅(frontend) Improve tests coverage
2222

23+
### Removed
24+
25+
- 🔥(back) remove footer endpoint
26+
2327
## [3.2.1] - 2025-05-06
2428

2529
## Fixed

docs/env.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@ These are the environmental variables you can set for the impress-backend contai
4949
| COLLABORATION_WS_URL | collaboration websocket url | |
5050
| FRONTEND_CSS_URL | To add a external css file to the app | |
5151
| FRONTEND_HOMEPAGE_FEATURE_ENABLED | frontend feature flag to display the homepage | false |
52-
| FRONTEND_FOOTER_FEATURE_ENABLED | frontend feature flag to display the footer | false |
53-
| FRONTEND_FOOTER_VIEW_CACHE_TIMEOUT | Cache duration of the json footer | 86400 |
54-
| FRONTEND_URL_JSON_FOOTER | Url with a json to configure the footer | |
5552
| FRONTEND_THEME | frontend theme to use | |
5653
| POSTHOG_KEY | posthog key for analytics | |
5754
| CRISP_WEBSITE_ID | crisp website id for support | |

env.d/development/common.dist

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,5 +64,3 @@ COLLABORATION_WS_URL=ws://localhost:4444/collaboration/ws/
6464

6565
# Frontend
6666
FRONTEND_THEME=default
67-
FRONTEND_FOOTER_FEATURE_ENABLED=True
68-
FRONTEND_URL_JSON_FOOTER=http://frontend:3000/contents/footer-demo.json

env.d/development/common.e2e.dist

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@ BURST_THROTTLE_RATES="200/minute"
44
DJANGO_SERVER_TO_SERVER_API_TOKENS=test-e2e
55
Y_PROVIDER_API_KEY=yprovider-api-key
66
Y_PROVIDER_API_BASE_URL=http://y-provider:4444/api/
7+
THEME_CUSTOMIZATION_FILE_PATH="" #force theme_customization to be empty

src/backend/core/api/viewsets.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
from core import authentication, enums, models
3434
from core.services.ai_services import AIService
3535
from core.services.collaboration_services import CollaborationService
36-
from core.services.config_services import get_footer_json
3736
from core.utils import extract_attachments, filter_descendants
3837

3938
from . import permissions, serializers, utils
@@ -1734,7 +1733,6 @@ def get(self, request):
17341733
"ENVIRONMENT",
17351734
"FRONTEND_CSS_URL",
17361735
"FRONTEND_HOMEPAGE_FEATURE_ENABLED",
1737-
"FRONTEND_FOOTER_FEATURE_ENABLED",
17381736
"FRONTEND_THEME",
17391737
"MEDIA_BASE_URL",
17401738
"POSTHOG_KEY",

src/backend/core/services/config_services.py

Lines changed: 0 additions & 25 deletions
This file was deleted.

src/backend/core/tests/test_api_config.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
COLLABORATION_WS_URL="http://testcollab/",
2222
CRISP_WEBSITE_ID="123",
2323
FRONTEND_CSS_URL="http://testcss/",
24-
FRONTEND_FOOTER_FEATURE_ENABLED=True,
2524
FRONTEND_THEME="test-theme",
2625
MEDIA_BASE_URL="http://testserver/",
2726
POSTHOG_KEY={"id": "132456", "host": "https://eu.i.posthog-test.com"},
@@ -45,7 +44,6 @@ def test_api_config(is_authenticated):
4544
"ENVIRONMENT": "test",
4645
"FRONTEND_CSS_URL": "http://testcss/",
4746
"FRONTEND_HOMEPAGE_FEATURE_ENABLED": True,
48-
"FRONTEND_FOOTER_FEATURE_ENABLED": True,
4947
"FRONTEND_THEME": "test-theme",
5048
"LANGUAGES": [
5149
["en-us", "English"],

src/backend/core/tests/test_api_footer.py

Lines changed: 0 additions & 81 deletions
This file was deleted.

src/backend/core/urls.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,4 @@
5656
),
5757
),
5858
path(f"api/{settings.API_VERSION}/config/", viewsets.ConfigView.as_view()),
59-
path(f"api/{settings.API_VERSION}/footer/", viewsets.FooterView.as_view()),
6059
]

src/backend/impress/settings.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -423,19 +423,6 @@ class Base(Configuration):
423423
environ_name="FRONTEND_HOMEPAGE_FEATURE_ENABLED",
424424
environ_prefix=None,
425425
)
426-
FRONTEND_URL_JSON_FOOTER = values.Value(
427-
None, environ_name="FRONTEND_URL_JSON_FOOTER", environ_prefix=None
428-
)
429-
FRONTEND_FOOTER_FEATURE_ENABLED = values.BooleanValue(
430-
default=False,
431-
environ_name="FRONTEND_FOOTER_FEATURE_ENABLED",
432-
environ_prefix=None,
433-
)
434-
FRONTEND_FOOTER_VIEW_CACHE_TIMEOUT = values.Value(
435-
60 * 60 * 24,
436-
environ_name="FRONTEND_FOOTER_VIEW_CACHE_TIMEOUT",
437-
environ_prefix=None,
438-
)
439426
FRONTEND_CSS_URL = values.Value(
440427
None, environ_name="FRONTEND_CSS_URL", environ_prefix=None
441428
)

0 commit comments

Comments
 (0)