Skip to content

Commit a603998

Browse files
committed
🏷️(frontend) improve props currentDocRole
props of currentDocRole is now more accurate.
1 parent 12d32fe commit a603998

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import { Doc, Role } from './types';
22

3-
export const currentDocRole = (doc: Doc): Role => {
4-
return doc.abilities.destroy
3+
export const currentDocRole = (abilities: Doc['abilities']): Role => {
4+
return abilities.destroy
55
? Role.OWNER
6-
: doc.abilities.manage_accesses
6+
: abilities.manage_accesses
77
? Role.ADMIN
8-
: doc.abilities.partial_update
8+
: abilities.partial_update
99
? Role.EDITOR
1010
: Role.READER;
1111
};

src/frontend/apps/impress/src/features/docs/doc-tools/components/DocToolBox.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export const DocToolBox = ({ doc }: DocToolBoxProps) => {
115115
<ModalAddMembers
116116
onClose={() => setIsModalAddMembersOpen(false)}
117117
doc={doc}
118-
currentRole={currentDocRole(doc)}
118+
currentRole={currentDocRole(doc.abilities)}
119119
/>
120120
)}
121121
{isModalPDFOpen && (

src/frontend/apps/impress/src/features/docs/docs-grid/components/DocsGrid.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,9 @@ export const DocsGrid = () => {
162162
renderCell: ({ row }) => {
163163
return (
164164
<StyledLink href={`/docs/${row.id}`}>
165-
<Text $weight="bold">{transRole(currentDocRole(row))}</Text>
165+
<Text $weight="bold">
166+
{transRole(currentDocRole(row.abilities))}
167+
</Text>
166168
</StyledLink>
167169
);
168170
},

src/frontend/apps/impress/src/features/docs/members/members-grid/components/MemberGrid.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ export const MemberGrid = ({ doc }: MemberGridProps) => {
110110
<MemberAction
111111
doc={doc}
112112
access={row}
113-
currentRole={currentDocRole(doc)}
113+
currentRole={currentDocRole(doc.abilities)}
114114
/>
115115
);
116116
},

0 commit comments

Comments
 (0)