Skip to content

Commit cdea75b

Browse files
committed
⚡️(ci) playwright install
Sometimes Playwwright installation fails on CI, it seems to arrive when we update the dependency cache. We will do a general install before installing the playwright browser to be sure everything is in place, it should be fast since we have the cache. We move the playwright installation before setting the docker container, so we will wait less if we have to retry the test because of the Playwwright installation.
1 parent 6a0d2e2 commit cdea75b

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/impress-frontend.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,12 +95,12 @@ jobs:
9595
- name: Set e2e env variables
9696
run: cat env.d/development/common.e2e.dist >> env.d/development/common.dist
9797

98+
- name: Install Playwright Browsers
99+
run: cd src/frontend/apps/e2e && yarn install --frozen-lockfile && yarn install-playwright chromium
100+
98101
- name: Start Docker services
99102
run: make bootstrap FLUSH_ARGS='--no-input' cache=
100103

101-
- name: Install Playwright Browsers
102-
run: cd src/frontend/apps/e2e && yarn install-playwright chromium
103-
104104
# Tool to wait for a service to be ready
105105
- name: Install Dockerize
106106
run: |
@@ -151,12 +151,12 @@ jobs:
151151
- name: Set e2e env variables
152152
run: cat env.d/development/common.e2e.dist >> env.d/development/common.dist
153153

154+
- name: Install Playwright Browsers
155+
run: cd src/frontend/apps/e2e && yarn install --frozen-lockfile && yarn install-playwright firefox webkit
156+
154157
- name: Start Docker services
155158
run: make bootstrap FLUSH_ARGS='--no-input' cache=
156159

157-
- name: Install Playwright Browsers
158-
run: cd src/frontend/apps/e2e && yarn install-playwright firefox webkit chromium
159-
160160
- name: Run e2e tests
161161
run: cd src/frontend/ && yarn e2e:test --project=firefox --project=webkit
162162

0 commit comments

Comments
 (0)