Skip to content

Commit eefbfc9

Browse files
AntoLCAntoLC
committed
fixup! ✨(backend) add is_masked to document list view
1 parent bb45308 commit eefbfc9

File tree

2 files changed

+25
-0
lines changed

2 files changed

+25
-0
lines changed

‎src/backend/core/tests/documents/test_api_documents_descendants.py

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ def test_api_documents_descendants_list_anonymous_public_standalone():
4242
"excerpt": child1.excerpt,
4343
"id": str(child1.id),
4444
"is_favorite": False,
45+
"is_masked": False,
4546
"link_reach": child1.link_reach,
4647
"link_role": child1.link_role,
4748
"numchild": 1,
@@ -66,6 +67,7 @@ def test_api_documents_descendants_list_anonymous_public_standalone():
6667
"excerpt": grand_child.excerpt,
6768
"id": str(grand_child.id),
6869
"is_favorite": False,
70+
"is_masked": False,
6971
"link_reach": grand_child.link_reach,
7072
"link_role": grand_child.link_role,
7173
"numchild": 0,
@@ -88,6 +90,7 @@ def test_api_documents_descendants_list_anonymous_public_standalone():
8890
"excerpt": child2.excerpt,
8991
"id": str(child2.id),
9092
"is_favorite": False,
93+
"is_masked": False,
9194
"link_reach": child2.link_reach,
9295
"link_role": child2.link_role,
9396
"numchild": 0,
@@ -139,6 +142,7 @@ def test_api_documents_descendants_list_anonymous_public_parent():
139142
"excerpt": child1.excerpt,
140143
"id": str(child1.id),
141144
"is_favorite": False,
145+
"is_masked": False,
142146
"link_reach": child1.link_reach,
143147
"link_role": child1.link_role,
144148
"numchild": 1,
@@ -161,6 +165,7 @@ def test_api_documents_descendants_list_anonymous_public_parent():
161165
"excerpt": grand_child.excerpt,
162166
"id": str(grand_child.id),
163167
"is_favorite": False,
168+
"is_masked": False,
164169
"link_reach": grand_child.link_reach,
165170
"link_role": grand_child.link_role,
166171
"numchild": 0,
@@ -183,6 +188,7 @@ def test_api_documents_descendants_list_anonymous_public_parent():
183188
"excerpt": child2.excerpt,
184189
"id": str(child2.id),
185190
"is_favorite": False,
191+
"is_masked": False,
186192
"link_reach": child2.link_reach,
187193
"link_role": child2.link_role,
188194
"numchild": 0,
@@ -255,6 +261,7 @@ def test_api_documents_descendants_list_authenticated_unrelated_public_or_authen
255261
"excerpt": child1.excerpt,
256262
"id": str(child1.id),
257263
"is_favorite": False,
264+
"is_masked": False,
258265
"link_reach": child1.link_reach,
259266
"link_role": child1.link_role,
260267
"numchild": 1,
@@ -277,6 +284,7 @@ def test_api_documents_descendants_list_authenticated_unrelated_public_or_authen
277284
"excerpt": grand_child.excerpt,
278285
"id": str(grand_child.id),
279286
"is_favorite": False,
287+
"is_masked": False,
280288
"link_reach": grand_child.link_reach,
281289
"link_role": grand_child.link_role,
282290
"numchild": 0,
@@ -299,6 +307,7 @@ def test_api_documents_descendants_list_authenticated_unrelated_public_or_authen
299307
"excerpt": child2.excerpt,
300308
"id": str(child2.id),
301309
"is_favorite": False,
310+
"is_masked": False,
302311
"link_reach": child2.link_reach,
303312
"link_role": child2.link_role,
304313
"numchild": 0,
@@ -356,6 +365,7 @@ def test_api_documents_descendants_list_authenticated_public_or_authenticated_pa
356365
"excerpt": child1.excerpt,
357366
"id": str(child1.id),
358367
"is_favorite": False,
368+
"is_masked": False,
359369
"link_reach": child1.link_reach,
360370
"link_role": child1.link_role,
361371
"numchild": 1,
@@ -378,6 +388,7 @@ def test_api_documents_descendants_list_authenticated_public_or_authenticated_pa
378388
"excerpt": grand_child.excerpt,
379389
"id": str(grand_child.id),
380390
"is_favorite": False,
391+
"is_masked": False,
381392
"link_reach": grand_child.link_reach,
382393
"link_role": grand_child.link_role,
383394
"numchild": 0,
@@ -400,6 +411,7 @@ def test_api_documents_descendants_list_authenticated_public_or_authenticated_pa
400411
"excerpt": child2.excerpt,
401412
"id": str(child2.id),
402413
"is_favorite": False,
414+
"is_masked": False,
403415
"link_reach": child2.link_reach,
404416
"link_role": child2.link_role,
405417
"numchild": 0,
@@ -478,6 +490,7 @@ def test_api_documents_descendants_list_authenticated_related_direct():
478490
"excerpt": child1.excerpt,
479491
"id": str(child1.id),
480492
"is_favorite": False,
493+
"is_masked": False,
481494
"link_reach": child1.link_reach,
482495
"link_role": child1.link_role,
483496
"numchild": 1,
@@ -500,6 +513,7 @@ def test_api_documents_descendants_list_authenticated_related_direct():
500513
"excerpt": grand_child.excerpt,
501514
"id": str(grand_child.id),
502515
"is_favorite": False,
516+
"is_masked": False,
503517
"link_reach": grand_child.link_reach,
504518
"link_role": grand_child.link_role,
505519
"numchild": 0,
@@ -522,6 +536,7 @@ def test_api_documents_descendants_list_authenticated_related_direct():
522536
"excerpt": child2.excerpt,
523537
"id": str(child2.id),
524538
"is_favorite": False,
539+
"is_masked": False,
525540
"link_reach": child2.link_reach,
526541
"link_role": child2.link_role,
527542
"numchild": 0,
@@ -580,6 +595,7 @@ def test_api_documents_descendants_list_authenticated_related_parent():
580595
"excerpt": child1.excerpt,
581596
"id": str(child1.id),
582597
"is_favorite": False,
598+
"is_masked": False,
583599
"link_reach": child1.link_reach,
584600
"link_role": child1.link_role,
585601
"numchild": 1,
@@ -602,6 +618,7 @@ def test_api_documents_descendants_list_authenticated_related_parent():
602618
"excerpt": grand_child.excerpt,
603619
"id": str(grand_child.id),
604620
"is_favorite": False,
621+
"is_masked": False,
605622
"link_reach": grand_child.link_reach,
606623
"link_role": grand_child.link_role,
607624
"numchild": 0,
@@ -624,6 +641,7 @@ def test_api_documents_descendants_list_authenticated_related_parent():
624641
"excerpt": child2.excerpt,
625642
"id": str(child2.id),
626643
"is_favorite": False,
644+
"is_masked": False,
627645
"link_reach": child2.link_reach,
628646
"link_role": child2.link_role,
629647
"numchild": 0,
@@ -728,6 +746,7 @@ def test_api_documents_descendants_list_authenticated_related_team_members(
728746
"excerpt": child1.excerpt,
729747
"id": str(child1.id),
730748
"is_favorite": False,
749+
"is_masked": False,
731750
"link_reach": child1.link_reach,
732751
"link_role": child1.link_role,
733752
"numchild": 1,
@@ -750,6 +769,7 @@ def test_api_documents_descendants_list_authenticated_related_team_members(
750769
"excerpt": grand_child.excerpt,
751770
"id": str(grand_child.id),
752771
"is_favorite": False,
772+
"is_masked": False,
753773
"link_reach": grand_child.link_reach,
754774
"link_role": grand_child.link_role,
755775
"numchild": 0,
@@ -772,6 +792,7 @@ def test_api_documents_descendants_list_authenticated_related_team_members(
772792
"excerpt": child2.excerpt,
773793
"id": str(child2.id),
774794
"is_favorite": False,
795+
"is_masked": False,
775796
"link_reach": child2.link_reach,
776797
"link_role": child2.link_role,
777798
"numchild": 0,

‎src/backend/core/tests/documents/test_api_documents_list.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ def test_api_documents_list_format():
7272
"depth": 1,
7373
"excerpt": document.excerpt,
7474
"is_favorite": True,
75+
"is_masked": False,
7576
"link_reach": document.link_reach,
7677
"link_role": document.link_role,
7778
"nb_accesses_ancestors": 3,
@@ -408,6 +409,7 @@ def test_api_documents_list_favorites_no_extra_queries(django_assert_num_queries
408409
assert len(results) == 5
409410

410411
assert all(result["is_favorite"] is False for result in results)
412+
assert all(result["is_masked"] is False for result in results)
411413

412414
# Mark documents as favorite and check results again
413415
for document in special_documents:
@@ -427,3 +429,5 @@ def test_api_documents_list_favorites_no_extra_queries(django_assert_num_queries
427429
assert result["is_favorite"] is True
428430
else:
429431
assert result["is_favorite"] is False
432+
# All documents should be unmasked in this test
433+
assert result["is_masked"] is False

0 commit comments

Comments
 (0)