Skip to content

Commit f2e5430

Browse files
bmcgavinAntoLC
authored andcommitted
🐛(helm) charts generate invalid YAML for collaboration API / WS
Closes #890 Remove the service blocks outside the conditionals in the collaboration API and WS templates. Signed-off-by: Richard Jones <[email protected]>
1 parent cd6e0ef commit f2e5430

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ and this project adheres to
88

99
## [Unreleased]
1010

11+
## Fixed
12+
13+
- 🐛(helm) charts generate invalid YAML for collaboration API / WS #890
14+
1115
## [3.4.2] - 2025-07-18
1216

1317
### Changed
@@ -141,7 +145,6 @@ and this project adheres to
141145
- 🐛(backend) race condition create doc #633
142146
- 🐛(frontend) fix breaklines in custom blocks #908
143147

144-
145148
## [3.1.0] - 2025-04-07
146149

147150
## Added

src/helm/impress/templates/ingress_collaboration_api.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@ spec:
5151
pathType: ImplementationSpecific
5252
{{- end }}
5353
backend:
54-
service:
55-
name: {{ include "impress.yProvider.fullname" . }}
56-
port:
57-
number: {{ .Values.yProvider.service.port }}
5854
{{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
5955
service:
6056
name: {{ include "impress.yProvider.fullname" . }}

src/helm/impress/templates/ingress_collaboration_ws.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@ spec:
5151
pathType: ImplementationSpecific
5252
{{- end }}
5353
backend:
54-
service:
55-
name: {{ include "impress.yProvider.fullname" . }}
56-
port:
57-
number: {{ .Values.yProvider.service.port }}
5854
{{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
5955
service:
6056
name: {{ include "impress.yProvider.fullname" . }}

0 commit comments

Comments
 (0)