⚡(backend) move email sending to celery #1236
Open
+21
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunika
reviewed
Aug 22, 2025
src/backend/core/tasks/mail.py
Outdated
| try: | ||
| document = models.Document.objects.get(id=document_id) | ||
| document.send_email(subject, emails, context, language) | ||
| except models.Document.DoesNotExist: |
There was a problem hiding this comment.
I would suggest to not fail silently. Let the exception bubbles, your monitoring system will warn you about this error. Because it is not normal to not find the document here.
There was a problem hiding this comment.
That's a good point. Removing the try/except clauses should allow the exception to bubble up then, right?
Thank you !
src/backend/core/tasks/mail.py
Outdated
| document = models.Document.objects.get(id=document_id) | ||
| sender = models.User.objects.get(id=sender_id) | ||
| document.send_invitation_email(email, role, sender, language) | ||
| except (models.Document.DoesNotExist, models.User.DoesNotExist): |
Move send_email and send_invitation_email operations to Celery tasks to prevent API endpoints from blocking while sending emails. Signed-off-by: Johann LORBER <[email protected]>
HaroWana
force-pushed
the
move_email_to_celery
branch
from
21e721d to
ce02929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes email sending asynchronous by moving email operations to Celery tasks, preventing API endpoints from blocking.
This pull request addresses issue #1143