✨(frontend) improve accessibility of search modal for screen readers #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/966-share-document-modal
branch
from
000bd17 to
de5958f
Compare
Ovgodd
force-pushed
the
fix/966-share-document-modal
branch
3 times, most recently
from
0da1580 to
391261c
Compare
added clearer sr-only translations and aria-hidden for non-essential content Signed-off-by: Cyril <[email protected]>
Ovgodd
force-pushed
the
fix/966-share-document-modal
branch
from
391261c to
81f3997
Compare
AntoLC
approved these changes
Aug 8, 2025
| @@ -180,7 +182,7 @@ export const DocVisibility = ({ doc }: DocVisibilityProps) => { | |||
| ) | |||
| : undefined | |||
| } | |||
| label={t('Visibility mode')} | |||
| label={t('Document access mode')} | |||
There was a problem hiding this comment.
Why switch from visibility to access ?
There was a problem hiding this comment.
It was for better clarity, as we’re switching from “edition” to “read-only” it’s essentially an access mode.
I’m open to other suggestions if this wording isn’t ideal :)
AntoLC
approved these changes
Aug 12, 2025
There was a problem hiding this comment.
I approved this PR already, I just had this question: #1275 (comment)
Yes I answer to it just below :D
Sorry the comment was in pending since 4 days.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Enhance the accessibility of the search modal for screen reader users by using clearer and more explicit translation strings and adding proper ARIA attributes.
improve e2e tests by adding data-testid
issue 966
Proposal